Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes in slts #30971

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Minor fixes in slts #30971

merged 4 commits into from
Jan 9, 2025

Conversation

ggevay
Copy link
Contributor

@ggevay ggevay commented Jan 8, 2025 •
edited
Loading

This PR makes a number of minor tweaks in slts, which accumulated on my todo list in the past months.

The commits are best reviewed individually.

Motivation

  • This PR refactors existing code.

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@ggevay ggevay marked this pull request as ready for review January 8, 2025 17:49
@ggevay ggevay requested a review from def- January 8, 2025 17:49
def-
def- approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@def- def- left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No complaints from my side! I'll run a nightly with the long SLT: https://buildkite.com/materialize/nightly/builds/10800
Edit: All green

@ggevay
Copy link
Contributor Author

ggevay commented Jan 9, 2025

Thank you!

@ggevay ggevay merged commit 3c610a2 into MaterializeInc:main Jan 9, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@def- def- def- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggevay @def-