Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix basis view message correlation on tagged interactions #786

Closed
therealryan opened this issue Apr 11, 2024 · 0 comments · Fixed by #843
Closed

Fix basis view message correlation on tagged interactions #786

therealryan opened this issue Apr 11, 2024 · 0 comments · Fixed by #843
Labels
bug Something isn't working javascript Pull requests that update Javascript code

Comments

@therealryan
Copy link
Contributor

It looks like the basis view (for example) isn't taking account of tags (which are required for dismabiguation when a flow features more than one interaction between the same two actors) when matching up interactions to compare.

We should look into that. Relevant code is here. It looks like it's doing the right thing, so we should make sure with a test first.
@therealryan therealryan added bug Something isn't working javascript Pull requests that update Javascript code labels Apr 11, 2024
@therealryan therealryan mentioned this issue Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Basis correlation fix Mastercard/flow
1 participant
@therealryan