Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessageHash masking #676

Closed
therealryan opened this issue Jan 3, 2024 · 0 comments · Fixed by #677
Closed

MessageHash masking #676

therealryan opened this issue Jan 3, 2024 · 0 comments · Fixed by #677
Labels
documentation Improvements or additions to documentation enhancement New feature or request java Pull requests that update Java code

Comments

@therealryan
Copy link
Collaborator

therealryan commented Jan 3, 2024

For some systems it's necessary to have dynamic fields (e.g.: a request might require a unique ID). If you represent that constraint in your model then you'll have difficulties with the MessageHash check - the dynamic field will produce a new hash every time you build the model.

This can be worked around by having the field be static in the model and overwriting it in the assertion components, but it might be more natural to have the field be dynamic in the model and reduce complexity in the assertion components.

In order to resolve the difficulty with hashing, we could apply masking operations before hashing to elide the dynamic fields. This wouldn't be a huge code change - we already have masking infrastructure - but the docs would need to carefully explain the two approaches.

@therealryan therealryan added enhancement New feature or request java Pull requests that update Java code documentation Improvements or additions to documentation labels Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request java Pull requests that update Java code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant