cache-locks #1402
Merged
cache-locks #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
| @@ -34,6 +34,7 @@ lua_shared_dict cache ${{MEM_CACHE_SIZE}}; | |||
| lua_shared_dict reports_locks 100k; | |||
| lua_shared_dict cluster_locks 100k; | |||
| lua_shared_dict cluster_autojoin_locks 100k; | |||
| lua_shared_dict cache_locks 100k; | |||
There was a problem hiding this comment.
we do not need so many different *_locks shared dicts. A single one is able to hold multiple locks with different options (expiration, timeout, etc...). It will be worth cleaning this up some time soon.
thibaultcha
added
pr/changes requested
|
@thibaultcha addressed last comments. |
| exptime = ASYNC_AUTOJOIN_INTERVAL - 0.001 | ||
| }) | ||
| if not lock then | ||
| ngx_log(ngx.ERR, "failed to init lock dictionary", err) |
There was a problem hiding this comment.
The err variable will tell what the error is. Should be "could not create lock: "
subnetmarco
added
pr/ready (but hold merge)
|
All comments addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When requesting a specific entity from the database, only one request to the database per node is allowed. This dramatically improves reliability during heavy load.
For example: let's say that 1000 req/s are being processed by a Kong node, and suddenly an in-memory entity is being invalidated and Kong needs to read it again from the database. Before this PR Kong would open 1000req/s to the database until that entity is stored into memory again. With this PR, only one read request will be opened to the database (per node), and the other requests (on the same node) will just wait until it's finally in memory again.
This also helps the performance of new nodes that are being added to the cluster (whose load goes from 0 to 100 real quick).
Closes #264.