Configurable Cassandra consistency level #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subnetmarco
force-pushed
the
feature/cassandra-consistency
branch
2 times, most recently
from
aac5204
to
d2268a0
Compare
|
@thibaultcha can you review this? |
| @@ -23,6 +23,7 @@ describe("Cassadra factory", function() | |||
| contact_points = dao_properties.contact_points, | |||
| keyspace = dao_properties.keyspace, | |||
| query_options = { | |||
| consistency = 1, | |||
There was a problem hiding this comment.
this should use the value from the cassandra.consistencies enum and not the underlying value
|
I have updated the PR. If it looks good I will squash and merge. |
|
Ok. Those tests don't exist in feature/postgres anyways
|
subnetmarco
force-pushed
the
feature/cassandra-consistency
branch
from
5da09df
to
3127eb8
Compare
subnetmarco
added
pr/ready (but hold merge)
subnetmarco
added a commit
that referenced
this pull request
Feb 26, 2016
Configurable Cassandra consistency level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1013.