Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4.7.0 - Minor Release #3548

Closed
12 tasks
MarshallOfSound opened this issue Apr 23, 2019 · 27 comments
Closed
12 tasks

Version 4.7.0 - Minor Release #3548

MarshallOfSound opened this issue Apr 23, 2019 · 27 comments

Comments

@MarshallOfSound
Copy link
Owner

This issue is for tracking progress on the release process.

  • Update MR_CHANGELOG
  • Version minor
  • Push to master
  • Build all platforms on CI
  • Check release process on staging update server staging.googleplaymusicdesktopplayer.com
  • Check operational on Windows
  • Check operational on OS X
  • Check operational on Linux
  • Make release on GitHub
  • Upload to bintray
  • Upload to WinStore
  • Watch the world burn 🔥 🚒
@MarshallOfSound
Copy link
Owner Author

MarshallOfSound commented Apr 23, 2019

RC Builds:

Please note that these builds are still versioned as 4.6.0.

Darwin

Linux

Windows

@MarshallOfSound MarshallOfSound pinned this issue Apr 23, 2019
@lguerard
Copy link

Hi,

Somehow, since the 4.7 update, the previous and next button on my mouse don't work anymore. Everything was fine with the previous version but not anymore.

@jostrander
Copy link
Collaborator

@lguerard What OS?

@csurett
Copy link

csurett commented Apr 25, 2019

The new RC breaks media controls in Gnome on Fedora 29. Compared to the releases on #3391

@baron-chiu
Copy link

baron-chiu commented Apr 26, 2019

Hi, MPRIS doesn't work with 4.7 on Ubuntu 18.10.2, while the MPRIS indicator can show current playing media with GPMDP 4.6.1 and VLC .

I am using Mpris Indicator Button and Media Player Indicator to test.
https://extensions.gnome.org/extension/55/media-player-indicator/
https://extensions.gnome.org/extension/1379/mpris-indicator-button/

With GPMDP 4.6.1, MPRIS indicator shows the song currently playing (at the right of the picture)
Screenshot from 2019-04-26 13-09-45

@lguerard
Copy link

What OS?

Linux Mint 19.1 (64bit). Sorry, I should have mentioned it before.

@mbradford-verys
Copy link

Can confirm that 4.7 breaks the back button and media controls on Ubuntu 18.04 (64 bit) as well.

@jostrander
Copy link
Collaborator

It seems YTM isn't properly reacting to track change events.

@neith00
Copy link

neith00 commented May 6, 2019

I confirm media button are broken on fedora 30!

@fastcat
Copy link

fastcat commented May 6, 2019

I observed the same thing when updating from one post-4.6 CI build (which became unstable after updating my Debian system from Stretch to Buster -- window would just go blank after a couple hours) to a newer one, which now has this bug. Looking at the commits between the dates on which I pulled CI packages, this stands out:

#3513 (review)

I don't have a linux machine to test this on but (a) it builds and (b) I have faith that between you and @jostrander this isn't broken

🙁 ?

Edit: for context, I'm using Gnome

@silentdis
Copy link

The 4.7 minor is playing great! It appears Discord linking, as well as Slack links are working. For some reason the notification doesn't go out to the KDE subsystems for media, so widgets/lock screen controls won't work.

I'm on Kubuntu 19.04.

@CharliePearce
Copy link

Can confirm that track change events don't affect Now Playing / Discord Rich Presence integrations in this minor version.

Tested under Windows 10 1903 (18362.116)

@fastcat
Copy link

fastcat commented Jun 4, 2019

I had hoped that #3569 would have fixed my media key / mpris issues noted above, but no such luck :(

Debian Buster (gnome 3.30.2)

@imaami
Copy link

imaami commented Jun 13, 2019

See #3553 (comment) for instructions on how to download the most recent dev build package.

@TurboGit
Copy link

Likewise for me, the media button are not working with 4.7. There is no problem with other players.

@JohnLGalt
Copy link

Q: Is this minor ver bump still based on Electron 3 (forgive my naivete, but in reading other bugs related to Google's Advanced Protection, I see that Electron 3 and 4 were mentioned in the reports, and from what I gleaned, GPMDP was E3 based, which is why it would not work with security keys - if this is incorrect, my apologies - please set me straight).

@jostrander
Copy link
Collaborator

Correct, this is still based on E3. I have a pull request that still needs some things flushed out in order to migrate to E4. Unfortunately I cant test everything as I don't have access to mac OS.

@JohnLGalt
Copy link

Cool. Would a Hackintosh setup wok for testing?

@silentdis
Copy link

Cool. Would a Hackintosh setup wok for testing?

I could also offer remote access to a Hackintosh VM running on Proxmox if you'd like.

@liedichi
Copy link

Can't seem to get the Discord rich presence to work.
I run GPMDP, Check the Enable Discord Rich Presence integration.
And nothing shows in discord, I have game activity enabled in discord.
Running on Windows 10 Home 64- bit (10.0, Build 18362)

I'm sorry if I'm being stupid. Don't know if i need to do or install anything else to get it to work had a look around but couldn't find an faq or anything else.

@dm3ch
Copy link

dm3ch commented Nov 8, 2019

Correct, this is still based on E3. I have a pull request that still needs some things flushed out in order to migrate to E4. Unfortunately I cant test everything as I don't have access to mac OS.

In case hakintosh is not an option - If you can describe test cases I could try to play them on my MacBook.

@jostrander
Copy link
Collaborator

Fairly certain I have it working, tried it on a Hackintosh and was able to get everything to seemingly work. Only thing I couldn't test was media keys and touch bar.

@dm3ch
Copy link

dm3ch commented Nov 8, 2019

Fairly certain I have it working, tried it on a Hackintosh and was able to get everything to seemingly work. Only thing I couldn't test was media keys and touch bar.

Maybe this tool would be useful for you - https://github.com/sindresorhus/touch-bar-simulator

@portaljacker
Copy link

Has there been any indication of when this'll go live? If not what's the most stable build? I want to try out the Slack stuff. (I would try the builds from the 2nd post but they're from May, though if it's the most stable to try out I guess that's fine too).

@benhbell
Copy link

Ubuntu 18.04 lts here, still have the Loading Music Library issue.

@MarshallOfSound
Copy link
Owner Author

Closing out, let's try this again

@MarshallOfSound
Copy link
Owner Author

New release issue --> #3761

Repository owner locked as resolved and limited conversation to collaborators Dec 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests