Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Background play is inconsistent #10

Closed
4 tasks done
MarmadileManteater opened this issue Jun 6, 2022 · 5 comments
Closed
4 tasks done

[Bug]: Background play is inconsistent #10

MarmadileManteater opened this issue Jun 6, 2022 · 5 comments
Assignees
@MarmadileManteater
Labels
B: inconsistent behavior bug Something isn't working

Comments

@MarmadileManteater
Copy link
Owner

MarmadileManteater commented Jun 6, 2022 •
edited
Loading

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.

Describe the bug

If the video is playing when the app enters the background, the video continues to pauses and refuses to play in the background. If the video is not playing when the app enters the background, it will be able to be played using the media controls notification. Then, the video will play to completion, and if autoplay is enabled, the next video will play and everything will continue on. There isn't a consistent way to forcibly pause the video before the app enters the background so that the system doesn't pause it and prevent the user from playing it. This issue is not present in audio formats.

Expected Behavior

The video should continue to play when the user enters the background, and it shouldn't prevent the video from being played while the app is in the background.

Issue Labels

inconsistent behavior

FreeTube Version

v0.16.0 66168e5

Operating System Version

Android 11, Kernel version 4.14.180-perf+ #1 Mon Mar 28 06:29:53 CDT 2022, Build number RPMS31.Q1-54-13.3-10

Installation Method (If applicable)

No response

Last Known Working FreeTube Version (If Any)

This feature never worked correctly

Primary API used

Invidious API

Additional Information

No response

Nightly Build
@MarmadileManteater MarmadileManteater added the bug Something isn't working label Jun 6, 2022
@MarmadileManteater MarmadileManteater self-assigned this Jun 6, 2022
@github-actions
Copy link

github-actions bot commented Oct 9, 2022

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@MarmadileManteater
Copy link
Owner Author

I just discovered a very helpful code snippet which was under the "quirks" section of the cordova-plugin-advanced-background README. I believe the web view optimizations were causing the video to pause when the app went into the background.

MarmadileManteater added a commit that referenced this issue Oct 31, 2022
@MarmadileManteater
Fix for #10
886299e 
The video still seems to stutter a little when the app initially enters
the background; however, this will mean that you can lock your screen
while a video is playing without losing your place or pausing the video.
@MarmadileManteater MarmadileManteater mentioned this issue Jan 22, 2023
Merged
@MarmadileManteater
Copy link
Owner Author

This is not an issue in my upcoming cordova-less update. Background play being inconsistent was a product of not being able to override the default functionality of pausing when the app closes in cordova. I could play the video after it was paused, but this was inconsistent and caused stuttering.

With just a vanilla webview app, however, I can simply override the behavior which calls the function that pauses the video when the app is put into the background.

@MarmadileManteater
Copy link
Owner Author

MarmadileManteater commented Feb 29, 2024 •
edited
Loading

The current nightly is now updated to the new cordova-less build.

MarmadileManteater added a commit that referenced this issue Apr 4, 2024
@MarmadileManteater
**Release 111**
624ba44 
##### ~~Cordova~~ Android specific changes:

- Switched away from Cordova [#101](#101 (comment))
  - Added ability to stream videos **locally** *without* proxying through invidious [#5](#5) 🥂
  - Added ability to seek in the media controls notification
  - Fixed videos stopping or stuttering when the app enters the background [#10](#10)
  - Fixed YT links not opening in app [#264](#264)
- Added ability to change where profiles/settings/playlists/history.db are located on the filesystem [#299](#299)
- Fullscreen videos now take up the entire screen instead of sharing real estate with the system UI

This release includes all of the changes from upstream release [0.20.0](https://github.com/FreeTubeApp/FreeTube/releases/tag/v0.20.0-beta).

  ...

  **Full Changelog**: 0.19.2.110...0.20.0.111
MarmadileManteater added a commit that referenced this issue Apr 4, 2024
@MarmadileManteater
**Release 111**
00a3d25 
##### ~~Cordova~~ Android specific changes:

- Switched away from Cordova [#101](#101 (comment))
  - Added ability to stream videos **locally** *without* proxying through invidious [#5](#5) 🥂
  - Added ability to seek in the media controls notification
  - Fixed videos stopping or stuttering when the app enters the background [#10](#10)
  - Fixed YT links not opening in app [#264](#264)
- Added ability to change where profiles/settings/playlists/history.db are located on the filesystem [#299](#299)
- Fullscreen videos now take up the entire screen instead of sharing real estate with the system UI

This release includes all of the changes from upstream release [0.20.0](https://github.com/FreeTubeApp/FreeTube/releases/tag/v0.20.0-beta).

  ...

  **Full Changelog**: 0.19.2.110...0.20.0.111
MarmadileManteater added a commit that referenced this issue Apr 4, 2024
@MarmadileManteater
**Release 111**
f848732 
##### ~~Cordova~~ Android specific changes:

- Switched away from Cordova [#101](#101 (comment))
  - Added ability to stream videos **locally** *without* proxying through invidious [#5](#5) 🥂
  - Added ability to seek in the media controls notification
  - Fixed videos stopping or stuttering when the app enters the background [#10](#10)
  - Fixed YT links not opening in app [#264](#264)
- Added ability to change where profiles/settings/playlists/history.db are located on the filesystem [#299](#299)
- Fullscreen videos now take up the entire screen instead of sharing real estate with the system UI

This release includes all of the changes from upstream release [0.20.0](https://github.com/FreeTubeApp/FreeTube/releases/tag/v0.20.0-beta).

  ...

  **Full Changelog**: 0.19.2.110...0.20.0.113
MarmadileManteater added a commit that referenced this issue Apr 4, 2024
@MarmadileManteater
**Release 111**
668d1ba 
##### ~~Cordova~~ Android specific changes:

- Switched away from Cordova [#101](#101 (comment))
  - Added ability to stream videos **locally** *without* proxying through invidious [#5](#5) 🥂
  - Added ability to seek in the media controls notification
  - Fixed videos stopping or stuttering when the app enters the background [#10](#10)
  - Fixed YT links not opening in app [#264](#264)
- Added ability to change where profiles/settings/playlists/history.db are located on the filesystem [#299](#299)
- Fullscreen videos now take up the entire screen instead of sharing real estate with the system UI

This release includes all of the changes from upstream release [0.20.0](https://github.com/FreeTubeApp/FreeTube/releases/tag/v0.20.0-beta).

  ...

  **Full Changelog**: 0.19.2.110...0.20.0.114
MarmadileManteater added a commit that referenced this issue Apr 4, 2024
@MarmadileManteater
**Release 115**
7890f6f 
##### ~~Cordova~~ Android specific changes:

- Switched away from Cordova [#101](#101 (comment))
  - Added ability to stream videos **locally** *without* proxying through invidious [#5](#5) 🥂
  - Added ability to seek in the media controls notification
  - Fixed videos stopping or stuttering when the app enters the background [#10](#10)
  - Fixed YT links not opening in app [#264](#264)
- Added ability to change where profiles/settings/playlists/history.db are located on the filesystem [#299](#299)
- Fullscreen videos now take up the entire screen instead of sharing real estate with the system UI

This release includes all of the changes from upstream release [0.20.0](https://github.com/FreeTubeApp/FreeTube/releases/tag/v0.20.0-beta).

  ...

  **Full Changelog**: 0.19.2.110...0.20.0.115
@MarmadileManteater
Copy link
Owner Author

This is now resolved by release 0.20.0.115.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarmadileManteater MarmadileManteater

Labels
B: inconsistent behavior bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MarmadileManteater