Manual Filament Change feature #3601

schirrel · 2016-04-23T16:02:58Z

Add the filament change routine.
States:

Remove FIlament
Insert Filament Slow
Insert Filament
Remove the filament, use a cert amout to retract, its value must be change according to your print
Insert slowly the filament until it pass the motor and enter the tube
Inser quick the filament till it reachs the end, the value to "walk" must be change according to your print

The feed rate used on it was but "eye". I made no calc to it, and i think that it also can change according to users need, or change it as you guys think is best.
Sorry but the lack of right words on description.

PS. It is not dealing with heating of the nozzle, it just move the "motor". In fact assumes that its already hot.

I'm looking ahead to implement this late next week.

jbrazio · 2016-04-23T17:37:26Z

You have to clean your code a little bit, the most important aspects are:

Do not use tabs anywhere, aways spaces
Use double space as the line ident base

jbrazio · 2016-04-23T17:39:59Z

Marlin/configuration_store.cpp

- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- *
- */
+   Marlin 3D Printer Firmware


On this file dfif there are a lot of changes unrelated with your functionality.

Yes i saw it two and i'm wordering why, cuz i havent change the comment, maybe by accident but i havent modified these

Maybe was the Arduino IDE identantion. I must change it again?

jbrazio · 2016-04-23T18:18:58Z

Marlin/Marlin_main.cpp

-  if (commands_in_queue < BUFSIZE) get_available_commands();
+
+
+if (filamentRemove) {


I don't like to use EEPROM nor having this hook at the mais loop()..

I'm just using EEPROM because the variable was used in the main loop.
And i have it there because i thugth that there were the right way but i could easily move to ultralcd.cpp file. What you think?

…guration_store

jbrazio · 2016-04-23T20:16:12Z

To reset files to their "default" use git checkout <filename>.

schirrel · 2016-04-23T23:13:31Z

@jbrazio i've done it 😄

Blue-Marlin · 2016-04-23T23:30:36Z

Marlin/language_en.h

+#define MSG_CHANGE_FILAMENT                 "Filament"
+#define MSG_REMOVE_FILAMENT                 "Remove"
+#define MSG_INSERT_FILAMENT                 "Insert"
+#define MSG_INSERT_FILAMENT_SLOW            "Slow Insert"
 #endif // LANGUAGE_EN_H


Why do we have that strange #ifndef #endif structures around the definitions in the English language file?
Do you see any warnings about redefined strings?
What language do you see for the new entries on your display if you set the language to pt-br?

Are these rhetorical questions you are asking? Your sarcasm doesn't necessarily translate. (But the contempt is loud and clear.)

Simple
straightforwardness
is
better.

Even better: just patch it up and submit a PR to his branch.

@Blue-Marlin i only have pasted my 4 variables at the end of the file i havent done any ifndef. ALso o see no warnings and i have done this 4 lines in pt-br file also, so i see it at my language.

@thinkyhead it was for me or for @Blue-Marlin? The question about sacarsm

Yes " rhetorical questions" and "sarcasm" have been addressed to me.

Ehhh, 'variables'?
No warnings?

from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\temperature.cpp:46: C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language_en.h:511:0: warning: "MSG_CHANGE_FILAMENT" redefined [enabled by default] #define MSG_CHANGE_FILAMENT "Filament" ^ In file included from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language.h:250:0, from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\temperature.cpp:46: C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language_pt-br.h:174:0: note: this is the location of the previous definition #define MSG_CHANGE_FILAMENT "Filamento" ^ In file included from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language.h:251:0, from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\temperature.cpp:46: C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language_en.h:512:0: warning: "MSG_REMOVE_FILAMENT" redefined [enabled by default] #define MSG_REMOVE_FILAMENT "Remove" ^ In file included from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language.h:250:0, from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\temperature.cpp:46: C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language_pt-br.h:175:0: note: this is the location of the previous definition #define MSG_REMOVE_FILAMENT "Retirar" ^ In file included from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language.h:251:0, from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\temperature.cpp:46: C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language_en.h:513:0: warning: "MSG_INSERT_FILAMENT" redefined [enabled by default] #define MSG_INSERT_FILAMENT "Insert" ^ In file included from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language.h:250:0, from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\temperature.cpp:46: C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language_pt-br.h:176:0: note: this is the location of the previous definition #define MSG_INSERT_FILAMENT "Inserir" ^ In file included from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language.h:251:0, from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\temperature.cpp:46: C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language_en.h:514:0: warning: "MSG_INSERT_FILAMENT_SLOW" redefined [enabled by default] #define MSG_INSERT_FILAMENT_SLOW "Slow Insert" ^ In file included from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language.h:250:0, from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\temperature.cpp:46: C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language_pt-br.h:177:0: note: this is the location of the previous definition #define MSG_INSERT_FILAMENT_SLOW "Lentamente" ^ "C:\Program Files (x86)\Arduino\hardware\tools\avr/bin/avr-g++" -c -g -Os -Wall -Wextra -std=gnu++11 -fno-exceptions -ffunction-sections -fdata-sections -fno-threadsafe-statics -MMD -mmcu=atmega2560 -DF_CPU=16000000L -DARDUINO=10608 -DARDUINO_AVR_MEGA2560 -DARDUINO_ARCH_AVR -fverbose-asm -save-temps "-IC:\Users\ah\AppData\Local\Arduino15\packages\arduino\hardware\avr\1.6.10\cores\arduino" "-IC:\Users\ah\AppData\Local\Arduino15\packages\arduino\hardware\avr\1.6.10\variants\mega" "-IC:\Users\ah\Documents\Arduino\libraries\U8glib\src" "C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\twibus.cpp" -o "C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\twibus.cpp.o" "C:\Program Files (x86)\Arduino\hardware\tools\avr/bin/avr-g++" -c -g -Os -Wall -Wextra -std=gnu++11 -fno-exceptions -ffunction-sections -fdata-sections -fno-threadsafe-statics -MMD -mmcu=atmega2560 -DF_CPU=16000000L -DARDUINO=10608 -DARDUINO_AVR_MEGA2560 -DARDUINO_ARCH_AVR -fverbose-asm -save-temps "-IC:\Users\ah\AppData\Local\Arduino15\packages\arduino\hardware\avr\1.6.10\cores\arduino" "-IC:\Users\ah\AppData\Local\Arduino15\packages\arduino\hardware\avr\1.6.10\variants\mega" "-IC:\Users\ah\Documents\Arduino\libraries\U8glib\src" "C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\ultralcd.cpp" -o "C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\ultralcd.cpp.o" In file included from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language.h:251:0, from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\ultralcd.cpp:26: C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language_en.h:511:0: warning: "MSG_CHANGE_FILAMENT" redefined [enabled by default] #define MSG_CHANGE_FILAMENT "Filament" ^ In file included from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language.h:250:0, from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\ultralcd.cpp:26: C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language_pt-br.h:174:0: note: this is the location of the previous definition #define MSG_CHANGE_FILAMENT "Filamento" ^ In file included from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language.h:251:0, from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\ultralcd.cpp:26: C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language_en.h:512:0: warning: "MSG_REMOVE_FILAMENT" redefined [enabled by default] #define MSG_REMOVE_FILAMENT "Remove" ^ In file included from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language.h:250:0, from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\ultralcd.cpp:26: C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language_pt-br.h:175:0: note: this is the location of the previous definition #define MSG_REMOVE_FILAMENT "Retirar" ^ In file included from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language.h:251:0, from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\ultralcd.cpp:26: C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language_en.h:513:0: warning: "MSG_INSERT_FILAMENT" redefined [enabled by default] #define MSG_INSERT_FILAMENT "Insert" ^ In file included from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language.h:250:0, from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\ultralcd.cpp:26: C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language_pt-br.h:176:0: note: this is the location of the previous definition #define MSG_INSERT_FILAMENT "Inserir" ^ In file included from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language.h:251:0, from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\ultralcd.cpp:26: C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language_en.h:514:0: warning: "MSG_INSERT_FILAMENT_SLOW" redefined [enabled by default] #define MSG_INSERT_FILAMENT_SLOW "Slow Insert" ^ In file included from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language.h:250:0, from C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\ultralcd.cpp:26: C:\Users\ah\AppData\Local\Temp\build0ca64bc2097fb2df5a6ea132866e93fd.tmp\sketch\language_pt-br.h:177:0: note: this is the location of the previous definition #define MSG_INSERT_FILAMENT_SLOW "Lentamente" ^

Yes, no warnings as you can see

Do you want to return to my first (rhetorical) question or do you want fotos from your pt-br - en mix?

okay i have to make the "ifndef" in english file, got it.

jbrazio · 2016-04-24T01:40:23Z

@codersquirrel está quase.. ;-)

Could you check Configuration_adv.h:

// Add support for experimental filament exchange support M600; requires display
#if ENABLED(ULTIPANEL)
  //#define FILAMENTCHANGEENABLE
  #if ENABLED(FILAMENTCHANGEENABLE)
    #define FILAMENTCHANGE_XPOS 3
    #define FILAMENTCHANGE_YPOS 3
    #define FILAMENTCHANGE_ZADD 10
    #define FILAMENTCHANGE_FIRSTRETRACT -2
    #define FILAMENTCHANGE_FINALRETRACT -100
    #define AUTO_FILAMENT_CHANGE                //This extrude filament until you press the button on LCD
    #define AUTO_FILAMENT_CHANGE_LENGTH 0.04    //Extrusion length on automatic extrusion loop
    #define AUTO_FILAMENT_CHANGE_FEEDRATE 300   //Extrusion feedrate (mm/min) on automatic extrusion loop
  #endif
#endif

thinkyhead · 2016-04-24T04:46:40Z

Marlin/ultralcd.cpp

+
+static void lcd_retract_filament() {
+ //This value must be setted according the size you have at your printer
+ current_position[E_AXIS] -= 75.0;


Make this number configurable in Configuration.h – don't hard-code it here.

schirrel · 2016-04-24T21:54:08Z

@jbrazio Obrigada ;-D i also will check this, and try to make this variable configurable, as @thinkyhead said.

schirrel · 2016-04-24T22:00:25Z

Yeah i know there's a lot to do about this feature. Like proper variable names, proper configuration. But i have done this to my use. For my own use i don't demand such things. But once i have done for me and it was something very handy, that i'm coming here to share and for you guys who have a better though on big projects, or entrepreneur, or i don't know how the hell call this type of thinking, but thinking a little bit more "organized" to help to make this the right way, and improve it for everyone's use.

…defines

Blue-Marlin · 2016-04-24T23:01:43Z

Marlin/language_en.h

+#endif
+#ifndef MSG_INSERT_FILAMENT_SLOW 
+ #define MSG_INSERT_FILAMENT_SLOW            "Slow Insert"
+#endif
 #endif // LANGUAGE_EN_H


😄
also, the travis check has failed at scara configuration :s
Could u help me?

Blue-Marlin · 2016-04-24T23:39:20Z

It's delta/kossel_mini what failed.
It's not the language file you changed but the commit before where you introduced

+#define FILAMENTCOMPLETCHANGE_SIZE 75
+#define FILAMENTCOMPLETCHANGE_FAST_FEEDRATE 100
+#define FILAMENTCOMPLETCHANGE_SLOW_FEEDRATE 1.5

in only one of the about 20 Configuration.h files, in combination with using this defines without checking there existence.

0.02s$ use_example_configs delta/kossel_mini

The command "use_example_configs delta/kossel_mini" exited with 0.

5.84s$ build_marlin

Loading configuration...

Xlib:  extension "RANDR" missing on display ":1.0".

Initializing packages...

Preparing boards...

Verifying...

ultralcd.cpp: In function 'void lcd_insert_filament_slow()':

ultralcd.cpp:1119: error: 'FILAMENTCOMPLETCHANGE_SLOW_FEEDRATE' was not declared in this scope

   plan_buffer_line(current_position[(X_AXIS)], current_position[(Y_AXIS)], current_position[(Z_AXIS)], current_position[E_AXIS], FILAMENTCOMPLETCHANGE_SLOW_FEEDRATE, active_extruder);

                                                                                                                                  ^

ultralcd.cpp: In function 'void lcd_retract_filament()':

ultralcd.cpp:1126: error: 'FILAMENTCOMPLETCHANGE_SIZE' was not declared in this scope

  current_position[E_AXIS] -= FILAMENTCOMPLETCHANGE_SIZE;

                              ^

ultralcd.cpp:1127: error: 'FILAMENTCOMPLETCHANGE_FAST_FEEDRATE' was not declared in this scope

  plan_buffer_line(current_position[(X_AXIS)], current_position[(Y_AXIS)], current_position[(Z_AXIS)], current_position[E_AXIS], FILAMENTCOMPLETCHANGE_FAST_FEEDRATE, active_extruder);

                                                                                                                                 ^

ultralcd.cpp: In function 'void lcd_insert_filament()':

ultralcd.cpp:1133: error: 'FILAMENTCOMPLETCHANGE_SIZE' was not declared in this scope

  current_position[E_AXIS] += FILAMENTCOMPLETCHANGE_SIZE;

                              ^

ultralcd.cpp:1134: error: 'FILAMENTCOMPLETCHANGE_FAST_FEEDRATE' was not declared in this scope

  plan_buffer_line(current_position[(X_AXIS)], current_position[(Y_AXIS)], current_position[(Z_AXIS)], current_position[E_AXIS], FILAMENTCOMPLETCHANGE_FAST_FEEDRATE, active_extruder);

                                                                                                                                 ^

'FILAMENTCOMPLETCHANGE_SLOW_FEEDRATE' was not declared in this scope

The command "build_marlin" exited with 1.

schirrel · 2016-04-24T23:46:33Z

@Blue-Marlin i'm just thinking, i have it set it in configuration where i thougth would be visible for every configuration. SHoud i change it to another file?
Or how could i solve it? i really dont know

thinkyhead · 2016-04-24T23:51:01Z

@codersquirrel Each configuration contains the whole, and some of them are used for the Travis tests. So whenever we add new things to the main config, we must also add them to all the other Configuration.h files in Marlin.

schirrel · 2016-04-25T00:02:04Z

@thinkyhead so it was travis problem not mine? cuz i add to the Configuration.h (yeah i'm a confused person, don't take me bad)

thinkyhead · 2016-04-25T00:32:54Z

cuz i add to the Configuration.h

Whenever we add new things to the main config, we must also add them to all the other Configuration.h files in Marlin.

$ find . -name Configuration.h
./Marlin/Configuration.h
./Marlin/example_configurations/adafruit/ST7565/Configuration.h
./Marlin/example_configurations/delta/biv2.5/Configuration.h
./Marlin/example_configurations/delta/generic/Configuration.h
./Marlin/example_configurations/delta/kossel_mini/Configuration.h
./Marlin/example_configurations/delta/kossel_pro/Configuration.h
./Marlin/example_configurations/delta/kossel_xl/Configuration.h
./Marlin/example_configurations/Felix/Configuration.h
./Marlin/example_configurations/Hephestos/Configuration.h
./Marlin/example_configurations/Hephestos_2/Configuration.h
./Marlin/example_configurations/K8200/Configuration.h
./Marlin/example_configurations/makibox/Configuration.h
./Marlin/example_configurations/RepRapWorld/Megatronics/Configuration.h
./Marlin/example_configurations/RigidBot/Configuration.h
./Marlin/example_configurations/SCARA/Configuration.h
./Marlin/example_configurations/TAZ4/Configuration.h
./Marlin/example_configurations/tvrrug/Round2/Configuration.h
./Marlin/example_configurations/WITBOX/Configuration.h

schirrel · 2016-04-25T00:39:18Z

WOW not i get sorry xD

thinkyhead · 2016-04-25T00:41:54Z

I removed your added config options anyway, so don't worry about it for now.

schirrel · 2016-04-25T00:45:47Z

@thinkyhead yes i saw it, i just wanted to make the pr with the green mark to "disengage of consciousness" i dont knwo if in english you have this expression, but its like to get this a closure. Anyway i stop working on this and will only work at yours

thinkyhead · 2016-04-25T00:47:05Z

In English: "peace of mind."

thinkyhead · 2016-04-25T01:38:03Z

So that our two branches are in sync, you should do just one more…

git checkout rc_filament_change_rcbugfix
git fetch upstream
git rebase upstream/RCBugFix
git push -f

Thanks!

thinkyhead · 2016-04-25T01:39:21Z

If all this git voodoo gets tiring, you can also use these helpful scripts: #3567

schirrel · 2016-04-25T01:42:19Z

@thinkyhead i'm following both to make this work lol

schirrel@inspiron:~/Github/RC5/Marlin$ git fetch upstream
fatal: 'upstream' does not appear to be a git repository
fatal: Could not read from remote repository.

thinkyhead · 2016-04-25T02:00:16Z

git add upstream [email protected]:MarlinFirmware/Marlin.git

thinkyhead · 2016-04-25T02:02:31Z

Helpful tip: Three backticks for multi-line code quoting.

```
My plaintext
goes on for
lines and lines
```

…gives us…

My plaintext
goes on for
lines and lines

…or for example…

```cpp
#define THING_IS_GOOD 1
if (THING_IS_GOOD) {
  run_away();
}
```

…gives us…

#define THING_IS_GOOD 1
if (THING_IS_GOOD) {
  run_away();
}

thinkyhead · 2016-04-26T02:13:38Z

@codersquirrel I thought you might get a lot out of this git tutorial. I know I did!

schirrel · 2016-04-27T16:12:55Z

@thinkyhead yeah i will follow and try to get your branch again, i'm just too busy this week xD

jbrazio · 2016-05-04T15:50:15Z

Due to #3605 this will be closed.

CoderSquirrel added 3 commits April 23, 2016 12:56

Change filament add to the menu

8439b97

Remove spaces in marlin main

87cf0bd

Moving variable to marlin main

3c62e76

schirrel mentioned this pull request Apr 23, 2016

Question about filament change (not bug) #3600

Closed

jbrazio reviewed Apr 23, 2016
View reviewed changes

jbrazio added PR: Improvement Needs: Work More work is needed labels Apr 23, 2016

jbrazio reviewed Apr 23, 2016
View reviewed changes

CoderSquirrel added 3 commits April 23, 2016 16:13

Fixing Issues. Moving functionatilies to ultralcd and restoring confi…

16c17e4

…guration_store

reset configuration

1099896

Everything working from ultralcd

4d4cf08

Blue-Marlin reviewed Apr 23, 2016
View reviewed changes

thinkyhead reviewed Apr 24, 2016
View reviewed changes

CoderSquirrel added 2 commits April 24, 2016 19:18

CREATE CONFIGURABLE VARIABLES

09b2db4

CREATE ifndef in language_en and change the local of filamentchanges …

2340f07

…defines

Blue-Marlin reviewed Apr 24, 2016
View reviewed changes

thinkyhead changed the title ~~Rc filament change rcbugfix~~ Manual Filament Change feature Apr 24, 2016

thinkyhead added PR: New Feature and removed PR: Improvement labels Apr 24, 2016

thinkyhead mentioned this pull request Apr 24, 2016

Manual Filament Change: A New Hope #3605

Closed

fix all configuration files

21fc34c

thinkyhead added the S: Experimental label Apr 25, 2016

jbrazio closed this May 4, 2016

jbrazio modified the milestone: 1.1.0 Jul 18, 2016

		if (commands_in_queue < BUFSIZE) get_available_commands();


		if (filamentRemove) {

Manual Filament Change feature #3601

Manual Filament Change feature #3601

Conversation

schirrel commented Apr 23, 2016 • edited Loading

jbrazio commented Apr 23, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jbrazio commented Apr 23, 2016

schirrel commented Apr 23, 2016

Blue-Marlin Apr 23, 2016 • edited by thinkyhead Loading

Choose a reason for hiding this comment

thinkyhead Apr 24, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jbrazio commented Apr 24, 2016

Choose a reason for hiding this comment

schirrel commented Apr 24, 2016

schirrel commented Apr 24, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Blue-Marlin commented Apr 24, 2016 • edited Loading

schirrel commented Apr 24, 2016

thinkyhead commented Apr 24, 2016 • edited Loading

schirrel commented Apr 25, 2016

thinkyhead commented Apr 25, 2016 • edited Loading

Whenever we add new things to the main config, we must also add them to all the other Configuration.h files in Marlin.

schirrel commented Apr 25, 2016

thinkyhead commented Apr 25, 2016

schirrel commented Apr 25, 2016

thinkyhead commented Apr 25, 2016

thinkyhead commented Apr 25, 2016

thinkyhead commented Apr 25, 2016 • edited Loading

schirrel commented Apr 25, 2016 • edited by thinkyhead Loading

thinkyhead commented Apr 25, 2016

thinkyhead commented Apr 25, 2016 • edited Loading

thinkyhead commented Apr 26, 2016

schirrel commented Apr 27, 2016

jbrazio commented May 4, 2016

schirrel commented Apr 23, 2016 •

edited

Loading

Blue-Marlin Apr 23, 2016 •

edited by thinkyhead

Loading

thinkyhead Apr 24, 2016 •

edited

Loading

Blue-Marlin commented Apr 24, 2016 •

edited

Loading

thinkyhead commented Apr 24, 2016 •

edited

Loading

thinkyhead commented Apr 25, 2016 •

edited

Loading

thinkyhead commented Apr 25, 2016 •

edited

Loading

schirrel commented Apr 25, 2016 •

edited by thinkyhead

Loading

thinkyhead commented Apr 25, 2016 •

edited

Loading