-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MKS H43 bug fix #21267
MKS H43 bug fix #21267
Conversation
Bugfix 2.0.x
Bugfix 2.0.x
Bugfix 2.0.x
Bugfix 2.0.x
Bugfix 2.0.x
Bugfix 2.0.x
Bugfix 2.0.x
Bugfix 2.0.x
Bugfix 2.0.x
Bugfix 2.0.x
thermalManager.setTargetHotend(newvalue, 1); | ||
acceptedvalue = thermalManager.temp_hotend[1].target; | ||
break; | ||
#endif | ||
#if HAS_HEATED_BED | ||
case VP_T_Bed_Set: | ||
if(newvalue > BED_MAXTEMP) newvalue = BED_MAXTEMP; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would not seem to matter since newvalue
is not being retained, and thermalManager
will reject the higher newvalue
as certainly as it will reject the reduced newvalue
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My other question is, why would the rejection of the set value matter to whether or not the display updates here? The only thing that should matter is whether the new value for display differs from what was previously displayed.
efb84fa
to
da74567
Compare
Co-authored-by: makerbase <[email protected]> Co-authored-by: MKS-Sean <[email protected]> Co-authored-by: Scott Lahteine <[email protected]>
Co-authored-by: makerbase <[email protected]> Co-authored-by: MKS-Sean <[email protected]> Co-authored-by: Scott Lahteine <[email protected]>
Co-authored-by: makerbase <[email protected]> Co-authored-by: MKS-Sean <[email protected]> Co-authored-by: Scott Lahteine <[email protected]>
Co-authored-by: makerbase <[email protected]> Co-authored-by: MKS-Sean <[email protected]> Co-authored-by: Scott Lahteine <[email protected]>
Description
This PR is to fix some problems of MKS H43:
1、Click repeatedly to move or return to zero for 60s, the motherboard is stuck.
2、The maximum temperature protection configured by the firmware is invalid.
3、The actual value of 0.01mm step of grid leveling is 0.11mm, and 0.11mm is also displayed in the display box.
4、Modify some header file paths.
Requirements
This PR is for MKS H43 display.
Related Issues
1、There is a phenomenon that the first point does not return to zero when using mesh leveling.
2、At MKS sgen_ L, you still need to define a serial port object for the display screen, so that no error will be reported during compilation.
3、During printing, the card is pulled out and inserted to continue printing without heating, and the extruder does not rotate.