-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Concept] TMC Sensorless Homing in M120/M121? #9742
Comments
The current implementation only enables the DIAG pin when homing and as far as Marlin knows, it's just a signal on a pin. So at the moment sensorless homing will not work with any abort on endstop hit feature. |
I modified |
@thinkyhead still need this one? |
this one has gone stale too and debate could move to discord Marlin Discord server. Join link: https://discord.gg/n5NJ59y |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The
M120
andM121
commands don't currently support sensorless homing. Should s.h. be enabled and disabled by these commands too?It would extend
M120
andM121
to enable/disable of sensorless homing per-axis, while only the real endstops would be enabled/disabled usingM120
/M121
with no parameters.The main use-case for
M120
/M121
is to enable endstops for the sake of the SD-abort-on-endstop-hit option. Outside of that it can be troublesome. IfM120
is activated and aG1
move hits an endstop the current position becomes "unknown." Since we don't try to correct the position based on the steps count, this makesM120
slightly dangerous. It is feasible to recover the position from the stepper counts (and we could add another G-code to do that).With sensorless homing it also becomes feasible to determine the position for any bump that stops the axis. But where and how to apply such a correction is not straightforward, especially for a print in progress. A position recovery re-home (as on Prusa MK3) makes the most sense.
The text was updated successfully, but these errors were encountered: