Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limiting_speed has a mistake #25978

Closed
1 task done
wczrui opened this issue Jun 14, 2023 · 1 comment
Closed
1 task done

limiting_speed has a mistake #25978

wczrui opened this issue Jun 14, 2023 · 1 comment

Comments

@wczrui
Copy link

wczrui commented Jun 14, 2023

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

The expression of variable limiting_speed has a mistake at line 301 in G2_3.cpp. The dimension of limiting_speed is mm_per_s, but the dimension of planner.settings.max_acceleration_mm_per_s2[axis_q] is mm_per_s2.
Please check it.

Bug Timeline

new bug

Expected behavior

limiting_speed = _MIN(planner.settings.max_feedrate_mm_s[axis_p], planner.settings.max_feedrate_mm_s[axis_q])

Actual behavior

limiting_speed = _MIN(planner.settings.max_feedrate_mm_s[axis_p], planner.settings.max_acceleration_mm_per_s2[axis_q])

Steps to Reproduce

No

Version of Marlin Firmware

2.1.2.1

Printer model

No response

Electronics

No response

Add-ons

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

No response

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant