[BUG] Adding a Controller fan causes compilation error for LPC1769 BOARD_MKS_SGEN_L_V2

[rondlh]

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

After updating to the latest bugfix-2.1.x 2023-04-27 I got compilation errors when enabling USE_CONTROLLER_FAN.
I got the following errors
undefined reference to GcodeSuite::M106() undefined reference to GcodeSuite::M107()

Bug Timeline

New bug as of 2023-04-27

Expected behavior

Compile like it used to before 2023-04-27

Actual behavior

Compilation errors:
undefined reference to GcodeSuite::M106() undefined reference to GcodeSuite::M107()

Steps to Reproduce

1. Start from the latest bugfix (2023-04-27)
2. In platformio.ini set "default_envs = LPC1769"
3. In configuration.h set the MOTHERBOARD to BOARD_MKS_SGEN_L_V2
4. In configuration_adv.h enable USE_CONTROLLER_FAN
5. In configuration_adv.h set "#define CONTROLLER_FAN_PIN P2_06"
6. Compile... then I get:

undefined reference to `GcodeSuite::M106()
undefined reference to `GcodeSuite::M107()

7. If I add "#define HAS_FAN 1" then compilation works fine.

Version of Marlin Firmware

Latest Marling 2.1.x bugfix 2023-04-27

Printer model

Custom

Electronics

MKS SGEN_L V2

Add-ons

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

• A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

Configuration_adv.zip

If I do the same configuration with another motherboard "default_envs = mks_monster8_usb_flash_drive_msc" and BOARD_MKS_MONSTER8_V1, then I DON'T have this problem.

[iLLiac4]

Hi. Have the same error. Where have you added #define HAS_FAN 1 ?

[ellensp]

broke on PR #25332

[rondlh]

Hi. Have the same error. Where have you added #define HAS_FAN 1 ?

Added in Configuration.h
Of course this is a quick fix, not recommended!

[ellensp]

yea issue is with source filtering deciding that M106 code is not needed and filtering it out..

[thinkyhead]

This is now patched. Thanks for the report!

[rondlh]

Confirmed, that fixed it, great job!

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.