[BUG] G38.2 does not work on COREXY

[aquaforum]

Did you test the latest bugfix-2.1.x code?

No, but I will test it now!

Bug Description

G38.2 does not sense signal from probe
I fixed it with this patch

diff -ur a/Marlin/src/module/endstops.cpp b/Marlin/src/module/endstops.cpp
--- a/Marlin/src/module/endstops.cpp	2022-12-19 22:42:28.000000000 +0200
+++ b/Marlin/src/module/endstops.cpp	2023-03-01 00:21:48.942400084 +0200
@@ -717,7 +717,7 @@
   #define UPDATE_ENDSTOP_BIT(AXIS, MINMAX) SET_BIT_TO(live_state, _ENDSTOP(AXIS, MINMAX), (READ_ENDSTOP(_ENDSTOP_PIN(AXIS, MINMAX)) != _ENDSTOP_INVERTING(AXIS, MINMAX)))
   #define COPY_LIVE_STATE(SRC_BIT, DST_BIT) SET_BIT_TO(live_state, DST_BIT, TEST(live_state, SRC_BIT))
 
-  #if ENABLED(G38_PROBE_TARGET) && NONE(CORE_IS_XY, CORE_IS_XZ, MARKFORGED_XY, MARKFORGED_YX)
+  #if ENABLED(G38_PROBE_TARGET)
     #define HAS_G38_PROBE 1
     // For G38 moves check the probe's pin for ALL movement
     if (G38_move) UPDATE_ENDSTOP_BIT(Z, TERN(USES_Z_MIN_PROBE_PIN, MIN_PROBE, MIN));

Explain, who knows why there is a check on COREXY and others?
config.zip

Bug Timeline

No response

Expected behavior

No response

Actual behavior

No response

Steps to Reproduce

No response

Version of Marlin Firmware

2.1.2

Printer model

Custom build COREXY

Electronics

MKS_GEN_L_V2

Add-ons

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

• A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

No response

[thisiskeithb]

It looks like this was first introduced in 0934563, but I'm not sure why it was restricted to exclude CoreXY/YX.

[thinkyhead]

I'm not sure why…

Perhaps stepper.axis_is_moving was only updated later, but G38 was missed in that update.

[thisiskeithb]

This will be fixed in #25713

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.