Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] compile fails when TEMP_SENSOR_BED set to not used #24833

Closed
1 task done
mAd-DaWg opened this issue Oct 5, 2022 · 4 comments
Closed
1 task done

[BUG] compile fails when TEMP_SENSOR_BED set to not used #24833

mAd-DaWg opened this issue Oct 5, 2022 · 4 comments

Comments

@mAd-DaWg
Copy link

mAd-DaWg commented Oct 5, 2022

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

Configured for a cnc machine. Compiling fails when TEMP_SENSOR_BED is set to 0. When its set to a dummy sensor it compiles.

Bug Timeline

newish issue as far as i am aware

Expected behavior

Expect the firmware to compile without issue when bed sensor is set to unused

Actual behavior

firmware fails to compile.

`Compiling .pio/build/BIGTREE_SKR_2/src/src/sd/cardreader.cpp.o
Compiling .pio/build/BIGTREE_SKR_2/src/src/sd/usb_flashdrive/Sd2Card_FlashDrive.cpp.o
Marlin/src/module/temperature.cpp: In static member function 'static void Temperature::task()':
Marlin/src/module/temperature.cpp:1855:7: error: 'gcode' was not declared in this scope
1855 | gcode.process_subcommands_now(F("M524"));
| ^~~~~
*** [.pio/build/BIGTREE_SKR_2/src/src/module/temperature.cpp.o] Error 1
============================================================================ [FAILED] Took 34.39 seconds ============================================================================

Environment Status Duration


BIGTREE_SKR_2 FAILED 00:00:34.387
======================================================================= 1 failed, 0 succeeded in 00:00:34.387 ==`

Steps to Reproduce

  1. Set temp sensors to 0
  2. Attempt to compile

Version of Marlin Firmware

Marlin-bugfix-2.1.x (4 Oct 2022)

Printer model

Custom built cnc

Electronics

SKR-2 rev b

Add-ons

No response

Bed Leveling

No response

Your Slicer

No response

Host Software

No response

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

Configuration.zip

@EvilGremlin
Copy link
Contributor

show full log with first error, you're just showing last eroor which is usually random meaningless garbage

@EvilGremlin
Copy link
Contributor

oooh, i got it - problem with include conditions
temperature.cpp - change line 66 to #if ANY(HAS_TEMP_SENSOR, LASER_FEATURE, SPINDLE_FEATURE)

@EvilGremlin
Copy link
Contributor

fixed in #24834

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants