Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Backlash compensation for IDEX #23794

Closed
EYHJ59 opened this issue Feb 24, 2022 · 3 comments
Closed

[BUG] Backlash compensation for IDEX #23794

EYHJ59 opened this issue Feb 24, 2022 · 3 comments

Comments

@EYHJ59
Copy link

EYHJ59 commented Feb 24, 2022

Did you test the latest bugfix-2.0.x code?

Yes, and the problem still exists.

Bug Description

For IDEX, when activate backlash compensation, layer shift is occurred.

Bug Timeline

Old one.

Expected behavior

No layer shift.

Actual behavior

No response

Steps to Reproduce

No response

Version of Marlin Firmware

Marlin V2.0.6

Printer model

No response

Electronics

No response

Add-ons

No response

Bed Leveling

No response

Your Slicer

No response

Host Software

No response

Additional information & file uploads

I changed add_correction_steps() (see below) and after that, I never seen layer shift.
My printer use X1/X2 motor and one Y motor.

void Backlash::add_correction_steps(const int32_t &da, const int32_t &db, const int32_t &dc, const uint8_t dm, block_t * const block) {

  static uint8_t last_direction_bits;
  if(backlash_extruder != active_extruder) {
    backlash_extruder = active_extruder;
    if(active_extruder == 0) last_direction_bits |= 0x01;
    else last_direction_bits &= 0xFE;
  }
  uint8_t changed_dir = last_direction_bits ^ dm;
  // Ignore direction change if no steps are taken in that direction
  if (da == 0) CBI(changed_dir, X_AXIS);
  if (db == 0) CBI(changed_dir, Y_AXIS);
  if (dc == 0) CBI(changed_dir, Z_AXIS);

  last_direction_bits ^= changed_dir;

  if (correction == 0) return;
  ~~~~~~~~~~~~~~~~~~~~~~~~~

I don't know my correction is right or not.
Can you check it is good or not?
Thank you in advance.

@ellensp
Copy link
Contributor

ellensp commented Feb 24, 2022

Either a duplicate of #23325 or #23741

@ellensp ellensp closed this as completed Feb 24, 2022
@thinkyhead
Copy link
Member

Duplicate of #23325

@thinkyhead thinkyhead marked this as a duplicate of #23325 Apr 21, 2022
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants