[BUG] X_AXIS_TWIST_COMPENSATION settings are not saved in EEPROM

[Giuseppe499]

Did you test the latest bugfix-2.0.x code?

Yes, and the problem still exists.

Bug Description

The settings of the feature X_AXIS_TWIST_COMPENSATION are not stored in EEPROM. When I use the X-Twist wizard, the correction values are computed, but if I save the settings to EEPROM and restart the printer the settings are not restored.

Bug Timeline

Marlin 2.0.9.3

Expected behavior

The settings for the feature X_AXIS_TWIST_COMPENSATION are restored after I save them and restart the printer

Actual behavior

When I use the X-Twist wizard, the correction values are computed, but if I save the settings to EEPROM and restart the printer the settings are not restored.

Steps to Reproduce

1. Run the X-Twist Wizard
2. Save Settings
3. Restart printer
4. Check if X_AXIS_TWIST_COMPENSATION settings are restored

Version of Marlin Firmware

Marlin 2.0.9.3

Printer model

Tronxy X8

Electronics

No response

Add-ons

BL Touch

Bed Leveling

ABL Bilinear mesh

Your Slicer

No response

Host Software

OctoPrint

Additional information & file uploads

Configurations.zip

[gordo3di]

Here's the code I used to save the x-twist values. I'm not sure if there is a better way to store the settings other than enqueuing M500 but it worked for me.

#23238 (comment)

[thisiskeithb]

#23745 has been merged.

[Giuseppe499]

Hi,

I tried the bugfix-2.0.x branch with X_AXIS_TWIST_COMPENSATION enabled on my TronxyX8, but it doesn't work.

After the merge of PR #23745, the printer always give me an EEPROM "Index Error" on startup. If I try to reset, save and load the settings I get the same EEPROM "Index Error".

I think that this problem is caused by the SettingsDataStruct being wrong in /Marlin/src/module/settings.cpp.
@thinkyhead made this change in the PR #23745:

  //
  // X_AXIS_TWIST_COMPENSATION
  //
  #if ENABLED(X_AXIS_TWIST_COMPENSATION)
-    float xatc_spacing, xatc_start;
-    xatc_array_t xatc_z_values; 
+    XATC xatc
  #endif

(Note: actually in the first commit of the PR the type xatc_array_t was named xatc_points_t)

If I revert this change, the problem is fixed.

I think that this problem should be fixed before closing this issue.

[thisiskeithb]

Since that PR has already been merged, can you submit a new one with the fix...again?

[thisiskeithb]

PR has been submitted: #23911

Thanks @ellensp!

[Giuseppe499]

Since that PR has already been merged, can you submit a new one with the fix...again?

I was about to submit the PR but @ellensp was much faster than me 😂 .

Thanks @ellensp!

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.