Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Compile error when commenting out SPINDLE_LASER_USE_PWM #23166

Closed
tbnobody opened this issue Nov 21, 2021 · 3 comments
Closed

[BUG] Compile error when commenting out SPINDLE_LASER_USE_PWM #23166

tbnobody opened this issue Nov 21, 2021 · 3 comments

Comments

@tbnobody
Copy link

Did you test the latest bugfix-2.0.x code?

Yes, and the problem still exists.

Bug Description

My spindle doesn't use a PWM control. So I commented out SPINDLE_LASER_USE_PWM in Configuration_adv.h

But then I get e.g. the following error message:
Marlin\src\feature\../module/../feature/spindle_laser_types.h:38:13: error: 'SPEED_POWER_MAX' was not declared in this scope

Imho this issue was introduced in this commit: de4eed3#diff-c7a3fa925098d81e51840820898b66e3d3e48f121a83e4d0b6c65e5ab4f2fba0R3400 because SPEED_POWER_MAX is no only defined if SPINDLE_LASER_USE_PWM is enabled.

Bug Timeline

No response

Expected behavior

No response

Actual behavior

No response

Steps to Reproduce

No response

Version of Marlin Firmware

2.0.9.2

Printer model

No response

Electronics

No response

Add-ons

No response

Bed Leveling

No response

Your Slicer

No response

Host Software

No response

Additional information & file uploads

No response

@descipher
Copy link
Contributor

Please retest, the merge should have resolved it

@tbnobody
Copy link
Author

Yes its working again! Thank you!

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants