Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Uncompilable for mega1280 #22135

Closed
vk-PyNoob opened this issue Jun 14, 2021 · 2 comments
Closed

[BUG] Uncompilable for mega1280 #22135

vk-PyNoob opened this issue Jun 14, 2021 · 2 comments

Comments

@vk-PyNoob
Copy link

vk-PyNoob commented Jun 14, 2021

Did you test the latest bugfix-2.0.x code?

Yes, and the problem still exists.

Bug Description

Error while build for Geetech2560 with mega1280:

In file included from Marlin\src\inc/../pins/mega/pins_GT2560_REV_A.h:31:0,
from Marlin\src\inc/../pins/pins.h:242,
from Marlin\src\inc/MarlinConfig.h:34,
from Marlin\src\MarlinCore.h:24,
from Marlin\src\MarlinCore.cpp:31:
Marlin\src\inc/../pins/mega/env_validate.h:27:4: error: #error "Oops! Select 'Arduino/Genuino Mega or Mega 2560' in 'Tools > Board.'"

I think that's because of this code in : Marlin\src\pins\mega\env_validate.h

#pragma once

#if ENABLED(ALLOW_MEGA1280) && NOT_TARGET(AVR_ATmega1280, AVR_ATmega2560)
#error "Oops! Select 'Arduino/Genuino Mega or Mega 2560 or 1280' in 'Tools > Board.'"
#elif NOT_TARGET(AVR_ATmega2560) <---
#error "Oops! Select 'Arduino/Genuino Mega or Mega 2560' in 'Tools > Board.'"
#endif

#undef ALLOW_MEGA1280

changing this:

#elif NOT_TARGET(AVR_ATmega2560)

to

#elif NOT_TARGET(AVR_ATmega1280, AVR_ATmega2560)

so it is compilable, but may be not correct

Steps to Reproduce

Set target to mega1280 & try to build

Version of Marlin Firmware

2.0.8.2 Latest & bugfix

Electronics

Geetech GT2560 Rev.A (with mega1280)

@ellensp
Copy link
Contributor

ellensp commented Jun 17, 2021

This is fixed, closing

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants