-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] start was changed to echo:start #20305
Comments
Answer here since other issue is locked.
Hosts also show non echo commands. Actually many firmwares do not even use echo: at all. But "start" is a control command just like "ok". As you already saw in the referenced thread simplify3d has problems with it. Same with other hosts like our software. So what you are doing is changing a many years old standard and expect all existing hosts to register the change and update and all users using newer marlin version to update the host software to make it work correctly instead of removing the 5 bytes added in Marlin? Such a thing is called breaking backward compatibility and that should be done for a good reason! |
The fix was merged. Thanks! |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Bug Description
Standard says that firmware starts with
start
but when I used latest commit I saw it now says
echo:start
which is against standards and can cause hosts to not detect a reset of printer if they watch for a line beginning with "start" and not a line containing "start" which could also be a file in listing or a M118 response or just a word in a message.
Configuration Files
Happens for all configs
Steps to Reproduce
Connect
Expected behavior:
Start communication with
start
Actual behavior:
Starts communication with
echo:start
Additional Information
Violation against many years old standard for communication.
The text was updated successfully, but these errors were encountered: