Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [Marlin 2.0.x] LCD messages 3 Point bedleveling #18634

Closed
roel8032 opened this issue Jul 13, 2020 · 12 comments
Closed

[BUG] [Marlin 2.0.x] LCD messages 3 Point bedleveling #18634

roel8032 opened this issue Jul 13, 2020 · 12 comments

Comments

@roel8032
Copy link

roel8032 commented Jul 13, 2020

Graphic LCD Marlin version 20006

LCD messages 3 Point bedleveling.

Anet A6. No need to see the configfiles. It is not in there.
My screen is in Dutch. Meetpunt is Probing Point.

3 point bedleveling
LCD message:
Probing point 1: LCD message: Probing Point 0/3
Probing point 2: LCD message: Probing Point 1/3
Probing point 3: LCD message: Probing Point 2/3

it should be:
Probing Point 1/3
Probing Point 2/3
Probing Point 3/3
LCD

@ellensp
Copy link
Contributor

ellensp commented Jul 13, 2020

and what lcd do you have? we cant tell, because you didn't include your Configuration files. Could be stock, could be anything.
Please attach your configuration files.

@ellensp
Copy link
Contributor

ellensp commented Jul 13, 2020

Your still missing the point, what if we need other settings? language? probe type? What version of marlin? and a million other questions.

We also want a configuration file that is full and complete so we can drop it in to marlin and replicate this issue.

Attach your config files! This is not optional.

@Lord-Quake
Copy link
Contributor

Lord-Quake commented Jul 13, 2020

@roel8032
I just tested it on my Ender 3 in UBL configuration, latest bug fix and it shows it correctly (1/3, 2/3 and 3/3) on the screen.

So.... post the information as requested by @ellensp. It won't kill you if you want to be helped here.

If I were you I'd install the latest bug fix version before I'd do anything else.

@roel8032
Copy link
Author

roel8032 commented Jul 13, 2020

OK.
But UBL (Unified Bed Leveling), is not AUTO_BED_LEVELING_3POINT
I just downloaded the latest. The same problem.

@Lord-Quake
Copy link
Contributor

I took a look at the code:

We might have to take a closer look at the following in G29.ccp and add i+1 to the string output:

    if (verbose_level) SERIAL_ECHOLNPAIR("Probing point ", int(i), "/3.");
    TERN_(HAS_DISPLAY, ui.status_printf_P(0, PSTR(S_FMT " %i/3"), GET_TEXT(MSG_PROBING_MESH), int(i)));

@roel8032
Copy link
Author

roel8032 commented Jul 13, 2020

Thanks. Now it is working OK

I changed this in:
\Marlin\src\feature\bedlevel\abl\G29.cpp

line689

//TERN_(HAS_DISPLAY, ui.status_printf_P(0, PSTR(S_FMT " %i/3"), GET_TEXT(MSG_PROBING_MESH), int(i)));
TERN_(HAS_DISPLAY, ui.status_printf_P(0, PSTR(S_FMT " %i/3"), GET_TEXT(MSG_PROBING_MESH), int(i+1)));

The old code above i commented.

Thank you.

lcd meetpunt_ok

@roel8032
Copy link
Author

and what lcd do you have? we cant tell, because you didn't include your Configuration files. Could be stock, could be anything.
Please attach your configuration files.

@roel8032
Copy link
Author

#define REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER
#define ST7920_DELAY_1 DELAY_NS(150)
#define ST7920_DELAY_2 DELAY_NS(150)
#define ST7920_DELAY_3 DELAY_NS(150)

But before i used with the same hardware:
//#define ANET_FULL_GRAPHICS_LCD

But since Marlin 2.0 that gives bad pictures

@Lord-Quake
Copy link
Contributor

I've put up a pull request: #18639

@Lord-Quake
Copy link
Contributor

The commit has been processed into the latest bug fix.
Please test once more and if it is working as expected close this issue.

@roel8032
Copy link
Author

Al working good in the latest bug fix.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants