[BUG] Dual Z, very bad sync after "Coolstep" implementation

[PGrave]

-After flashing my SKR Pro with Marlin bugfix version from today, aprox. 15:00, my Z dual drive setup has a very rough motion and noise, ultimately halting the system. Had some problems compiling before, Z2 and Coolstep related, as Sanity check would require Z2 to be setup but Z2 drive configuration was removed from Configuration. h, on the Coolstep implementation.

My Configurations

My configurations are included in the zip file, hardware is:
Ender 3 Pro; BTT SKR Pro V1.1; 5x BTT TMC2209 V1.0; dual Z steppers;
MyConfigs.zip

Steps to Reproduce

1. Compile Marlin bugfix;
2. Flash firmware;
3. Move Z axis and notice rough, unsynched movement between Z steppers

Expected behavior: [What you expect to happen]
-Sync between Z steppers

Actual behavior: [What actually happens]
-Unsynched movement between Z steppers

[daleckystepan]

I have tried to disable Coolstep using
#define Z_COOLSTEP_LOWER_LOAD_THRESHOLD 0
without any success. But you can try it on your own.

[PGrave]

I did try to disable Coolstep for Z, with no success.
I think that something has happened with the steps/mm assignment for the 2nd Z stepper: it seems it stays with the ones configured for E, instead of those for Z. In my case, that means almost half of the movement, which could explain the grinding and the machine halting.

[thisiskeithb]

CoolStep was removed in 18a7276. It wasn't ready for use after all.

[Fabi0San]

@PGrave can you please test with the latest bits?
We need to disambiguate whether the problem was with CoolStep or with the new way to config Z2, etc.
As described in this comment by @thinkyhead: #16823 (comment)

[thinkyhead]

In future all this driver malarkey will be organized more consistently. I had hoped to get a jump on that by extending the auto-assignment stuff, but the codebase needs more massaging before it will be ready. So, that part of the coolstep patch has now been reverted. Please grab the latest Marlin, replace the old driver type options in your config, and we'll revisit that again when things are more in place.

[ghost]

@Fabi0San so wait, according to the comment, if one has a tmc2209 as Z2 plugged (on the board) in E1, does that mean "#define E1_DRIVER_TYPE" defines the correct driver for Z2 ?
I had the same issue with coolstep (re-arm 2x tmc2209 for Z1 & 2) but thought "#define Z_DRIVER_TYPE" would define the driver for both Zx ?
If so, maybe a sanitycheck is necessary, something like "if NUM_Z/X_STEPPER_DRIVERS >= 2 and E1_DRIVER_TYPE is undefined = error" ?

With coolstep on, and a clean eeprom, Z2 seems to not load the Z2 configs and the TMC driver menu only shows X / Y / Z / E1 (Z2 is gone, in any submenu, hybrid threshold / current / etc).

[Fabi0San]

Yes, @thinkyhead will correct me if I'm wrong but the goal was to Z_DRIVER_TYPE set the driver type for both, but that has since been reverted 71539bc

So sync to latest bugfix, revert to your old ways of defining types for z and z2 and hold on for CoolStep until we untangle this.

[PGrave]

@Fabi0San , I didn't test further, but my thoughts were just how I described in OP: not a Coolstep problem in itself, but a drive assignment logic problem. Thank you all for the help, I'll proceed as suggested by @thinkyhead and close this issue.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.