Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] FAN1 does not work #16730

Closed
LorenzoSaini opened this issue Jan 30, 2020 · 5 comments
Closed

[BUG] FAN1 does not work #16730

LorenzoSaini opened this issue Jan 30, 2020 · 5 comments

Comments

@LorenzoSaini
Copy link

I don't know if it is a bug related to my SKR PRO board, I downloaded the latest marlin 2.0.2 firmware, the issue is than i can't turn on FAN1 by "M106 P1 S255", i duble checked the configuration, configuration_adv and pins_btt_skr_pro_v1_1.h files, in marlin 2.0.1 work as expected.
I don't use Software PWM, Extruder autofan and FAN0 works fine.

config.zip

Thanks for the replies.

@LorenzoSaini
Copy link
Author

LorenzoSaini commented Jan 30, 2020

i have found a solution, in conditionals_post.h. line 1221 and below
-Replace
#define HAS_FAN0 (PIN_EXISTS(FAN)) #define _HAS_FAN(P) (PIN_EXISTS(FAN_##P) && CONTROLLER_FAN_PIN != FAN_##P##_PIN && E0_AUTO_FAN_PIN != FAN_##P##_PIN && E1_AUTO_FAN_PIN != FAN_##P##_PIN && E2_AUTO_FAN_PIN != FAN_##P##_PIN && E3_AUTO_FAN_PIN != FAN_##P##_PIN && E4_AUTO_FAN_PIN != FAN_##P##_PIN && E5_AUTO_FAN_PIN != FAN_##P##_PIN && E6_AUTO_FAN_PIN != FAN_##P##_PIN && E7_AUTO_FAN_PIN != FAN_##P##_PIN) #define HAS_FAN1 _HAS_FAN(1) #define HAS_FAN2 _HAS_FAN(2) #define HAS_FAN3 _HAS_FAN(3) #define HAS_FAN4 _HAS_FAN(4) #define HAS_FAN5 _HAS_FAN(5) #define HAS_FAN6 _HAS_FAN(6) #define HAS_FAN7 _HAS_FAN(7) #define HAS_CONTROLLER_FAN (PIN_EXISTS(CONTROLLER_FAN))
With this From previous build:
#define HAS_FAN0 (PIN_EXISTS(FAN)) #define HAS_FAN1 (PIN_EXISTS(FAN1) && CONTROLLER_FAN_PIN != FAN1_PIN && E0_AUTO_FAN_PIN != FAN1_PIN && E1_AUTO_FAN_PIN != FAN1_PIN && E2_AUTO_FAN_PIN != FAN1_PIN && E3_AUTO_FAN_PIN != FAN1_PIN && E4_AUTO_FAN_PIN != FAN1_PIN && E5_AUTO_FAN_PIN != FAN1_PIN) #define HAS_FAN2 (PIN_EXISTS(FAN2) && CONTROLLER_FAN_PIN != FAN2_PIN && E0_AUTO_FAN_PIN != FAN2_PIN && E1_AUTO_FAN_PIN != FAN2_PIN && E2_AUTO_FAN_PIN != FAN2_PIN && E3_AUTO_FAN_PIN != FAN2_PIN && E4_AUTO_FAN_PIN != FAN2_PIN && E5_AUTO_FAN_PIN != FAN2_PIN) #define HAS_CONTROLLER_FAN (PIN_EXISTS(CONTROLLER_FAN))

Conditionals_post.zip

@LorenzoSaini LorenzoSaini changed the title [BUG] FAN1 does not work on SKR PRO [BUG] FAN1 does not work Jan 30, 2020
@GMagician
Copy link
Contributor

Have you checked #16717? It should fix your issue

@boelle
Copy link
Contributor

boelle commented Jan 30, 2020

and bugfix 2.0.x should be working again, it had a few hours yesterday where it would not compile

@LorenzoSaini
Copy link
Author

Yes, seems that #16717 has fixed the issue, thanks for the report, tomorrow i will test the bugfix branch.

@github-actions
Copy link

github-actions bot commented Jul 3, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants