Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Software endstops are ignored #16373

Closed
phate191 opened this issue Dec 29, 2019 · 18 comments
Closed

[BUG] Software endstops are ignored #16373

phate191 opened this issue Dec 29, 2019 · 18 comments

Comments

@phate191
Copy link

Bug Description

After Homing with Software Endostops enabled, you can move out of the software endostops boundaries.

My Configurations

Ender 3 Pro
Version 2.0.1, commit 432decd
Marlin.zip

Steps to Reproduce

  1. M211 //Check if Software Endsotops are Enabled
  2. Home XY [G91 | G28 X0 Y0 | G90]
  3. M211 //Check, Still Enabled
  4. G1 Y-1 F4000 // Move Y and the axis move without problem...

With Software Endstops enabled the axes after home should be stopped to go below MIN_SOFTWARE_ENDSTOP_*

From Octoprint Terminal:

Send: M211
Recv: echo:Soft endstops: ON Min: X0.00 Y0.00 Z0.00 Max: X235.00 Y235.00 Z250.00
Recv: ok
[...]
Send: G91
Recv: ok
[...]
Send: G28 X0 Y0
[...]
Recv: echo:busy: processing
[...]
Recv: echo:busy: processing
[...]
Recv: X:0.00 Y:0.00 Z:10.00 E:0.00 Count X:0 Y:0 Z:4000
Recv: ok
Send: G90
Recv: ok
[...]
Send: M211
Recv: echo:Soft endstops: ON Min: X0.00 Y0.00 Z0.00 Max: X235.00 Y235.00 Z250.00
Recv: ok
[...]
Send: G1 Y-1 F4000
Recv: ok

I've also tried to disable with M211 S0 and the repeat; the beavior is the same (and it's ok).

@ellensp
Copy link
Contributor

ellensp commented Dec 29, 2019

Endstops are ignored for all but homing commands. unless you enable
#define ENDSTOPS_ALWAYS_ON_DEFAULT in Configuration_adv.h

@phate191
Copy link
Author

phate191 commented Dec 29, 2019

Yes true, but phisical endstops must be separated from software endstops.
Theoretically they have different function.
If I remeber correctly, in old versions, software endostops if are enabled are always enforced.

EDIT:
Also with #define ENDSTOPS_ALWAYS_ON_DEFAULT enabled, I can go above the bed limit (bed size 235 x 235) if I use G1 Y236 F4000

@tatusah
Copy link

tatusah commented Dec 30, 2019

Different board but for me soft endstops do work correctly with Marlin 2.0.1. What does M114 report as position after you issue the G1 Y-1 F4000?

@tatusah
Copy link

tatusah commented Dec 30, 2019

Does the LCD controls also allow going past soft endstops or is it only trough Octoprint?

@phate191
Copy link
Author

Ok I think I find the issue.
This is the ouput from octoprint if I only home X and Y:

[...]
Send: G91
Recv: ok
Send: G28 X0 Y0
[...]
Recv: echo:busy: processing
[...]
Recv: echo:busy: processing
[...]
Recv: X:0.00 Y:0.00 Z:10.00 E:0.00 Count X:0 Y:0 Z:4000
Recv: ok
Send: G90
Recv: ok
[...]
Send: M114
Recv: X:0.00 Y:0.00 Z:10.00 E:0.00 Count X:0 Y:0 Z:4000
Recv: ok
[...]
Send: G1 Y-1 F4000
Recv: ok
[...]
Send: M114
Recv: X:0.00 Y:-1.00 Z:10.00 E:0.00 Count X:0 Y:-80 Z:4000
Recv: ok

But this is the ouput after home of X, Y and Z:

[...]
Send: G91
Recv: ok
Send: G28 X0 Y0
[...]
Recv: echo:busy: processing
[...]
Recv: echo:busy: processing
[...]
Recv: X:0.00 Y:0.00 Z:10.00 E:0.00 Count X:0 Y:0 Z:4000
Recv: ok
Send: G90
Recv: ok
Send: G91
Recv: ok
Send: G28 Z0
[...]
Recv: echo:busy: processing
[...]
Recv: echo:busy: processing
[...]
Recv: echo:busy: processing
[...]
Recv: X:0.00 Y:0.00 Z:0.00 E:0.00 Count X:0 Y:0 Z:0
Recv: ok
Send: G90
Recv: ok
[...]
Send: M114
Recv: X:0.00 Y:0.00 Z:0.00 E:0.00 Count X:0 Y:0 Z:0
Recv: ok
[...]
Send: G1 Y-1 F4000
Recv: ok
[...]
Send: M114
Recv: X:0.00 Y:0.00 Z:0.00 E:0.00 Count X:0 Y:0 Z:0
Recv: ok

So, if you home only X and Y, and then you move X or Y, software and hardware endstops are ignored for ALL axis :(

@tatusah
Copy link

tatusah commented Dec 30, 2019

Well, there you are correct. Sorry, did only test general G28 previously. Software endstops are not enabled until all axis are homed and thus movement past endstops is possible.

@tatusah
Copy link

tatusah commented Dec 30, 2019

And I remembered that I saw this thing before also. The issue connects to a bigger picture. It was last raised here #16283 so I think this needs some discussion about what if anything should be done about the situation.

@kurtnelle
Copy link

I have confirmed that the software endstops are on but the joystick still allows the planner to send the axis beyond the frame of the machine.

@boelle
Copy link
Contributor

boelle commented Jan 7, 2020

@phate191 still an issue?

@kurtnelle
Copy link

I had to update to the lastest version of marlin. I think the software endstops work now. However the behaviour with the joysticks is so erratic, that I'm not sure if it actually is working.

@kurtnelle
Copy link

I've tested it some more. Its not working.

@boelle
Copy link
Contributor

boelle commented Jan 18, 2020

did you test it before or after pr #16533 was merged?

@boelle
Copy link
Contributor

boelle commented Jan 23, 2020

Lack of Activity
This issue is being closed due to lack of activity. If you have solved the
issue, please let us know how you solved it. If you haven't, please tell us
what else you've tried in the meantime, and possibly this issue will be
reopened.

we can reopen if we hear from @phate191 again

@kurtnelle
Copy link

@boelle , I haven't tested it after #16533 cause I can't figure out how to merge!

@boelle boelle closed this as completed Jan 24, 2020
@boelle
Copy link
Contributor

boelle commented Jan 24, 2020

@italocjs
Copy link
Contributor

I have the same issue, i'll try burning the latest bugfix (from today) to verify if it was solved

@italocjs
Copy link
Contributor

I can confirm that #16533 has fixed the issue here!, thanks

@github-actions
Copy link

github-actions bot commented Jul 3, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants