Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Add sanity check for Z_STEPPER_ALIGN_XY #16170

Closed
MoshiBin opened this issue Dec 9, 2019 · 5 comments
Closed

[FR] Add sanity check for Z_STEPPER_ALIGN_XY #16170

MoshiBin opened this issue Dec 9, 2019 · 5 comments
Labels
T: Feature Request Features requested by users.

Comments

@MoshiBin
Copy link
Contributor

MoshiBin commented Dec 9, 2019

Description

Currently, setting coordinates in Z_STEPPER_ALIGN_XY that cannot be reached by the probe (due to a probe offset, for example) compiles successfully but fails during G32.

I'm suggesting adding a sanity check to make sure Z_STEPPER_ALIGN_XY is valid for the currently set bed size and probe offset.

@InsanityAutomation
Copy link
Contributor

@boelle this can get closed. This can now be calculated at runtime as well eliminating the need to set the variable in most cases. It can also be overridden with M422.

@boelle boelle closed this as completed Feb 4, 2020
@ahmetcemturan
Copy link

When No coordinates are entered it will compile and upload, but when You try to execute a Z-leveling (G34) You get an Error. (Probing failed) Note that Auto Bed leveling works fine...
If I override with M422 and enter 25, 100 and 190, 100 it works. But these coordinates are the limit. (In correspondence with 25mm probe from edge and Bed-size.

What I want to say is I have basically entered what leaving the coordinates commented out should have assumed.

My Probe limits are:
#define NOZZLE_TO_PROBE_OFFSET { 18, 12 , -2}

#define MIN_PROBE_EDGE 25

#define X_BED_SIZE 215
#define Y_BED_SIZE 195

#define X_MIN_POS 0
#define Y_MIN_POS 0
#define Z_MIN_POS 0
#define X_MAX_POS 215
#define Y_MAX_POS 195
#define Z_MAX_POS 170

@randellhodges
Copy link
Contributor

randellhodges commented May 9, 2020

I am using Z_STEPPER_AUTO_ALIGN and I do not have Z_STEPPER_ALIGN_XY defined and it probes just fine.

I am on about a month old version of bugfix however, so maybe this is only in newer versions.

@sjasonsmith
Copy link
Contributor

I am the same as @randellhodges. Three point auto-selection is fine for me, although also slightly older.

Try enabling DEBUG_LEVELING_FEATURE (and enable prints with the gcode in the comment next to it), and see if it reports the points it is trying to use.

It would be better to continue discussing this over on discord or another support forum to help figure out if it is a configuration issue or a bug. If it is a bug it should be reported as a me issue and not tracked onto a closed one.

@github-actions
Copy link

github-actions bot commented Jul 9, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: Feature Request Features requested by users.
Projects
None yet
Development

No branches or pull requests

6 participants