Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Buffer SLOWDOWN allow custom/user threshold #13834

Closed
reloxx13 opened this issue Apr 27, 2019 · 3 comments
Closed

[FR] Buffer SLOWDOWN allow custom/user threshold #13834

reloxx13 opened this issue Apr 27, 2019 · 3 comments
Labels
T: Feature Request Features requested by users.

Comments

@reloxx13
Copy link
Contributor

reloxx13 commented Apr 27, 2019

Description

Currently the SLOWDOWN threshold is 50% of buffer. So it will slowdown if the buffer is half empty.

Now if i set a higher buffer, i have more commands which are still waiting in the buffer and i dont need to slowdown at 50%, rather at 25%.

Example1: Default
Buffer max 50 commands
Half 25 commands
=> Slowdown

Example2: Higher Buffer
Buffer max 100 commands
Half 50 commands, still enough
Now at quater 25 commands left
=> Slowdown

Conclusion

It would be nice if the user can define the slowdown threshold himself, but set default at 50%.
The boards are also getting better and will have a higher buffer.

Or the other way around, eg if octoprint is too slow transfering the commands, a higher threshold could gain some important time to avoid printhead stops which result in blobs.

Config example:

// If defined the movements slow down when the look ahead buffer is under given percentage
#define SLOWDOWN 25 //in percent (default 50)
@reloxx13 reloxx13 changed the title [FR] Buffer SLOWDOWN user threshold [FR] Buffer SLOWDOWN allso custom/user threshold Apr 27, 2019
@reloxx13 reloxx13 changed the title [FR] Buffer SLOWDOWN allso custom/user threshold [FR] Buffer SLOWDOWN allow custom/user threshold Apr 27, 2019
@boelle boelle added the T: Feature Request Features requested by users. label Jul 21, 2019
@vadsh
Copy link

vadsh commented Jan 26, 2020

I believe that would be a great feature. 50% with large buffer is not good. Custom threshold seems to be easy to implement and useful.

@sjasonsmith
Copy link
Contributor

This was added about 6 months ago:
#17171

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: Feature Request Features requested by users.
Projects
None yet
Development

No branches or pull requests

4 participants