Protobuf gencode version 5.27.2 is older then the runtime version 5.28.1 at playwright.proto

[Houbein]

Describe the bug
In version 18.8.1 rfbrowserinit fails with the following error:
Failed to download Chromium 129.0.6668.29 (playwright build v1134) caused by Download failure, code=1
at ChildProcess. (c:\Python312\Lib\site-packages\Browser\wrapper\node_modules\playwright-core\lib\server\registry\browserFetcher.js:91:16)

There is also a warning:
c:\Python312\Lib\site-packages\google\protobuf\runtime_version.py:122: UserWarning: Protobuf gencode version 5.27.2 is older then the runtime version 5.28.1 at playwright.proto. Please avoid checked-in Protobuf gencode that can be obsolete.

To Reproduce
Install version 18.8.1
run rfbrowserinit

Desktop:

• OS: Windows 10 22h2

Additional context
Downgrading to 18.8.0 solves the issue.

[aaltat]

The download is controlled by Playwright and we can’t fix it. Because we run Windows also in our CI, the binary should be there, have you retried the installation and see what it says?

The protobuf warning is Browser library problem and I did notice it too after the release. Need to see how it can be fixed.

[Houbein]

Cause found, 18.8.1 calls for chromium 1134 which seems to have not been picked up by our internal mirror yet.
18.8.0 uses 1129 which is present.

[aaltat]

@allcontributors please add @Houbein for bugs

[allcontributors]

@aaltat

I've put up a pull request to add @Houbein! 🎉

[aaltat]

I think this is caused by protocolbuffers/protobuf#18096 and we need to wait for new release from protobuf.

[Snooz82]

We fixed it so, that we have now downgraded the protobuf version.

[Houbein]

I understand, but I don't really consider a downgrade to be a "fix".
I know I'm a bit of an LCM freak (ask my team), but in my opinion the only path ever should be up.
So I do not consider this issue to be fixed until a new version of protobuf is implemented.
Always forward, never backwards!