Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badges show wrong numbers #2

Open
dasdom opened this issue Aug 10, 2022 · 3 comments
Open

Badges show wrong numbers #2

dasdom opened this issue Aug 10, 2022 · 3 comments

Comments

@dasdom
Copy link

dasdom commented Aug 10, 2022

Expected behavior

As a user I expect the badges next to the menu items show the number of elements in that category.

Observed behavior

When I select the ObjC category, the badges next to Swift and Others vanish and the badge next to Any shows the same number as the one next to ObjC.

Screenshots

Screenshot 2022-08-10 at 08 49 31

Steps to reproduce

  1. Open App
  2. Select Objective-C

Environment

  • App version 1.0.0 (1)
  • macOS 12.4 (21F79)
  • XCSnippetsApp was started from the download folder
@MarcoEidinger
Copy link
Owner

I find this a nice feature to get a breakdown of snippets per platform based on the selected snippet category.

SideBarBadgeBehavior.mp4

But you would prefer that all the badge numbers stay as-is?

@dasdom
Copy link
Author

dasdom commented Aug 10, 2022

What I do not understand: Why do all Swift snippets vanish if I select to see all ObjC snippets in the list on the right?

If this is intentional, go for it.

@MarcoEidinger
Copy link
Owner

Can you elaborate on your statement?

Why do all Swift snippets vanish if I select to see all ObjC snippets in the list on the right?

For me, an empty list of snippets on the middle column only occurs if there are no matching snippets for the selected filter, e.g. no Objective-C snippets specific to macOS.

I am willing to consider the filter behavior and I'd gladly appreciate your feedback. Do you think the platform filter is useful? Should this filter be additive to the language filter (as it is right now)? Any other thoughts on filtering in the sidebar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants