Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement in-app titlebar and esc to go back #89

Open
MarcAnt01 opened this issue Oct 25, 2021 · 2 comments
Open

Implement in-app titlebar and esc to go back #89

MarcAnt01 opened this issue Oct 25, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@MarcAnt01
Copy link
Owner

Currently the titlebar has a hacky back button that is a bit too small for touch targets and isn't consistent with apps like snipping tool using an in-app titlebar.
It's also necessary to implement esc to go back functionality

@MarcAnt01 MarcAnt01 added the enhancement New feature or request label Oct 25, 2021
@JaiganeshKumaran
Copy link
Contributor

Instead of duplicating the custom title bar in each top-level page, have a single top-level page and show the separate pages inside a frame under the page. Most apps do it this way so you get the same title bar.

@MarcAnt01
Copy link
Owner Author

Hey @JaiganeshKumaran , I totally lost this message, now there's a proper in-app titlebar button (from 3.0 branch), while esc to go back still has to be implemented.
If you think that having a top level page is better, feel free to send a pr, anyway consider that the back button is needed only in some pages, while in others it shouldn't be there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants