Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix internal vrp import #349

Merged
merged 9 commits into from
Mar 24, 2022
Merged

Fix internal vrp import #349

merged 9 commits into from
Mar 24, 2022

Conversation

braktar
Copy link
Contributor

@braktar braktar commented Feb 14, 2022

No description provided.

@braktar braktar requested a review from senhalil February 14, 2022 08:15
@braktar braktar force-pushed the fix-internal-vrp-import branch 2 times, most recently from 0720d69 to 2f2f336 Compare March 8, 2022 10:02
@braktar braktar marked this pull request as ready for review March 8, 2022 10:03
@braktar braktar mentioned this pull request Mar 8, 2022
Merged
1 task
senhalil
senhalil reviewed Mar 8, 2022
View reviewed changes
api/v01/entities/vrp_input.rb Show resolved Hide resolved
lib/interpreters/split_clustering.rb Show resolved Hide resolved
models/base.rb Outdated Show resolved Hide resolved
models/quantity.rb Outdated Show resolved Hide resolved
@braktar braktar force-pushed the fix-internal-vrp-import branch 4 times, most recently from d153335 to 95a011f Compare March 9, 2022 14:17
@braktar braktar requested a review from senhalil March 9, 2022 14:18
braktar
braktar commented Mar 9, 2022
View reviewed changes
models/quantity.rb Outdated Show resolved Hide resolved
@braktar braktar force-pushed the fix-internal-vrp-import branch 2 times, most recently from babf0da to e08e77a Compare March 10, 2022 09:34
senhalil
senhalil reviewed Mar 10, 2022
View reviewed changes
Copy link
Contributor

@senhalil senhalil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last crinkles

api/v01/vrp.rb Outdated Show resolved Hide resolved
lib/interpreters/split_clustering.rb Show resolved Hide resolved
models/quantity.rb Outdated Show resolved Hide resolved
models/relation.rb Show resolved Hide resolved
models/relation.rb Outdated Show resolved Hide resolved
wrappers/wrapper.rb Show resolved Hide resolved
@braktar braktar force-pushed the fix-internal-vrp-import branch 2 times, most recently from 657746b to bb4d76d Compare March 15, 2022 15:42
@braktar braktar requested a review from senhalil March 16, 2022 11:22
senhalil
senhalil reviewed Mar 17, 2022
View reviewed changes
models/service.rb Outdated Show resolved Hide resolved
@senhalil
Copy link
Contributor

Can we merge Linked_ids and linked_service_ids are currently most of the time dupl… and Get rid of linked_ids? The last one removes/modifies most of everything done by the first one.

@senhalil
Copy link
Contributor

@braktar The following bug still active on this branch unfortunately
[2022-03-17T18:17:53.073031172+01:00] 1b369389f94ec1e252bcb9fbf605c5e5 - FATAL: ActiveHash::RecordNotFound: Couldn't find Models::Rest with ID="r190465419"

@braktar
Copy link
Contributor Author

braktar commented Mar 18, 2022

Couldn't find Models::Rest with ID="r190465419" is now fixed

senhalil
senhalil reviewed Mar 18, 2022
View reviewed changes
models/vrp.rb Outdated Show resolved Hide resolved
senhalil
senhalil reviewed Mar 18, 2022
View reviewed changes
models/service.rb Outdated Show resolved Hide resolved
@braktar
Copy link
Contributor Author

braktar commented Mar 21, 2022

Each mission_ids should refer to an existant id should be fixed

@braktar braktar requested a review from senhalil March 21, 2022 10:33
@braktar braktar force-pushed the fix-internal-vrp-import branch 2 times, most recently from 7c08cd4 to 985ca9c Compare March 21, 2022 15:28
@braktar braktar force-pushed the fix-internal-vrp-import branch 4 times, most recently from e21afaa to b5c54ef Compare March 24, 2022 13:52
@braktar braktar force-pushed the fix-internal-vrp-import branch from b5c54ef to c15dc09 Compare March 24, 2022 14:29
@senhalil senhalil marked this pull request as draft March 24, 2022 14:35
@senhalil senhalil marked this pull request as ready for review March 24, 2022 14:35
@senhalil senhalil closed this Mar 24, 2022
@senhalil senhalil reopened this Mar 24, 2022
@senhalil senhalil merged commit a354552 into Mapotempo:dev Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senhalil senhalil senhalil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braktar @senhalil