Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skills in scheduling #194

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Skills in scheduling #194

merged 2 commits into from
Jun 18, 2021

Conversation

fonsecadeline
Copy link
Contributor

@fonsecadeline fonsecadeline commented Apr 21, 2021 •
edited
Loading

@fonsecadeline fonsecadeline requested review from senhalil and braktar May 27, 2021 09:30
@fonsecadeline fonsecadeline force-pushed the skills_in_scheduling branch from 95e97a1 to 284a00e Compare May 27, 2021 09:30
@fonsecadeline fonsecadeline marked this pull request as ready for review May 27, 2021 09:31
senhalil
senhalil suggested changes May 27, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
lib/heuristics/concerns/scheduling_data_initialisation.rb Outdated Show resolved Hide resolved
lib/heuristics/concerns/scheduling_end_phase.rb Outdated Show resolved Hide resolved
test/lib/heuristics/scheduling_test.rb Show resolved Hide resolved
test/lib/heuristics/scheduling_test.rb Show resolved Hide resolved
lib/heuristics/scheduling_heuristic.rb Outdated Show resolved Hide resolved
senhalil
senhalil suggested changes May 27, 2021
View reviewed changes
Copy link
Contributor

@senhalil senhalil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current implementation cannot handle multiple skill_sets

lib/heuristics/scheduling_heuristic.rb Outdated Show resolved Hide resolved
@fonsecadeline fonsecadeline force-pushed the skills_in_scheduling branch 3 times, most recently from 1f7bc34 to c334b48 Compare May 28, 2021 07:23
@fonsecadeline fonsecadeline requested a review from senhalil May 28, 2021 07:24
@fonsecadeline fonsecadeline mentioned this pull request Jun 4, 2021
Merged
1 task
@fonsecadeline fonsecadeline force-pushed the skills_in_scheduling branch 2 times, most recently from 35f1349 to 70dda39 Compare June 4, 2021 13:42
braktar
braktar reviewed Jun 4, 2021
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
lib/heuristics/concerns/scheduling_end_phase.rb Outdated Show resolved Hide resolved
@fonsecadeline fonsecadeline force-pushed the skills_in_scheduling branch 3 times, most recently from d728545 to b6ad769 Compare June 7, 2021 12:25
@fonsecadeline fonsecadeline requested a review from braktar June 7, 2021 15:56
senhalil
senhalil suggested changes Jun 10, 2021
View reviewed changes
wrappers/wrapper.rb Outdated Show resolved Hide resolved
@fonsecadeline fonsecadeline force-pushed the skills_in_scheduling branch from b6ad769 to 91c7af0 Compare June 10, 2021 12:34
@fonsecadeline fonsecadeline requested a review from senhalil June 10, 2021 12:34
@fonsecadeline fonsecadeline force-pushed the skills_in_scheduling branch 2 times, most recently from 808e7d2 to b094d6d Compare June 11, 2021 06:38
braktar
braktar suggested changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@braktar braktar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both :
test/lib/interpreters/split_clustering_test.rb:501:in 'test_fail_when_alternative_skills'
and
test/lib/interpreters/split_clustering_test.rb:962:in 'test_split_with_vehicle_alternative_skills'
fail with the error : Minitest::UnexpectedError: OptimizerWrapper::DiscordantProblemError: Periodic heuristic does not support vehicle alternative skills

@fonsecadeline fonsecadeline force-pushed the skills_in_scheduling branch from b094d6d to bbc4997 Compare June 11, 2021 12:08
@fonsecadeline fonsecadeline requested a review from braktar June 11, 2021 12:08
@fonsecadeline fonsecadeline force-pushed the skills_in_scheduling branch from bbc4997 to 8956cb4 Compare June 16, 2021 08:33
@fab-girard fab-girard merged commit e44f968 into Mapotempo:dev Jun 18, 2021
@fonsecadeline fonsecadeline deleted the skills_in_scheduling branch June 18, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senhalil senhalil senhalil approved these changes

@braktar braktar braktar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fonsecadeline @braktar @senhalil @fab-girard