Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: config map enabled elements is not properly scoped #307

Open
razbroc opened this issue Jul 29, 2024 · 5 comments
Open

bug: config map enabled elements is not properly scoped #307

razbroc opened this issue Jul 29, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@razbroc
Copy link
Contributor

razbroc commented Jul 29, 2024

image

in case of tracing.enabled set to false, it won't be set to false in configmap - and be undefined instead

@razbroc razbroc added the bug Something isn't working label Jul 29, 2024
@razbroc razbroc self-assigned this Jul 29, 2024
@shimoncohen
Copy link
Contributor

As mentioned here:
https://github.com/MapColonies/telemetry?tab=readme-ov-file#tracing-configuration

The valid values are true and false, but in case of undefined the env value would be removed as such:
https://github.com/MapColonies/telemetry/blob/a09788899eb40945ce79632f2ca516a6d7626c3d/src/common/config.ts#L44-L48

Have you run in to an issue where the undefined value was actually passed? If not, I think this issue can be closed.

@razbroc
Copy link
Contributor Author

razbroc commented Jul 31, 2024

the problem is that the env would be removed. people tend to query this value in their code and expect to get true or false , in this case they get undefined - querying a non-existent value.

@shimoncohen
Copy link
Contributor

It's not a problem if you use our telemetry package.
As I mentioned before it sets the value to be false as default when the env is undefined.

@razbroc
Copy link
Contributor Author

razbroc commented Jul 31, 2024

i need to check further, but i think the bug is caused because of out helm hierarchy, global is trying to run over the 'undfiend' value which causes the problem.
image

@shimoncohen
Copy link
Contributor

@razbroc Can this issue be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants