Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent duplicate tiles in task creation #29

Merged
merged 3 commits into from
Nov 25, 2024
Merged

fix: prevent duplicate tiles in task creation #29

merged 3 commits into from
Nov 25, 2024

Conversation

almog8k
Copy link
Collaborator

@almog8k almog8k commented Nov 24, 2024

Question Answer
Bug fix ✔
New feature ✖
Breaking change ✖
Deprecations ✖
Documentation ✖
Tests added ✖
Chore ✖

CL-SHLOMIKONCHA
CL-SHLOMIKONCHA requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@CL-SHLOMIKONCHA CL-SHLOMIKONCHA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good overall, i would recommend to change "geo1" and "geo2" vars naming to someting like: currentPartGeometry & comparedPartGeometry same with "footprint1" & "footprint2"

@almog8k almog8k merged commit e8fed18 into master Nov 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CL-SHLOMIKONCHA CL-SHLOMIKONCHA CL-SHLOMIKONCHA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@almog8k @CL-SHLOMIKONCHA