feat: Ingestion update finalize(MAPCO-4442) #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CL-SHLOMIKONCHA
requested changes
Oct 29, 2024
src/job/models/jobHnadler.ts
Outdated
src/job/models/jobHnadler.ts
Outdated
|
|
||
| protected async markFinalizeStepAsCompleted<T>(jobId: string, taskId: string, step: keyof T, finalizeTaskParams: T): Promise<T> { | ||
| const updatedParams: T = { ...finalizeTaskParams, [step]: true }; | ||
| await this.queueClient.jobManagerClient.updateTask(jobId, taskId, { parameters: updatedParams }); |
There was a problem hiding this comment.
Add debug log for step 'x' marked as completed after update action
src/job/models/jobHnadler.ts
Outdated
| } | ||
|
|
||
| protected async markFinalizeStepAsCompleted<T>(jobId: string, taskId: string, step: keyof T, finalizeTaskParams: T): Promise<T> { | ||
| const updatedParams: T = { ...finalizeTaskParams, [step]: true }; |
There was a problem hiding this comment.
Define type FinalizeTaskParams and use it instead of the generic T
There was a problem hiding this comment.
export type FinalizeTaskParams = IngestionNewFinalizeTaskParams | IngestionUpdateFinalizeTaskParams | IngestionSwapUpdateFinalizeTaskParams;
<T extends FinalizeTaskParams>
src/job/models/jobHnadler.ts
Outdated
| import { Logger } from '@map-colonies/js-logger'; | ||
| import { layerNameSchema } from '../../utils/zod/schemas/jobParametersSchema'; | ||
|
|
||
| export abstract class JobHandler { |
| }); | ||
| expect(catalogClientMock.update).toHaveBeenCalledWith(job); | ||
| expect(jobManagerClientMock.updateTask).toHaveBeenCalledWith(job.id, task.id, { parameters: { updatedInCatalog: true } }); | ||
| expect(queueClientMock.ack).toHaveBeenCalledWith(job.id, task.id); |
There was a problem hiding this comment.
Please add updateJob toHaveBeenCalledTimes(1)
There was a problem hiding this comment.
already exists (changed hierarchy for clarity )
CL-SHLOMIKONCHA
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further information:
*Handling
finalizetask forIngestion_Update*Remove configuration for isNewTarget flag (useNewTargetFlag)