Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: aggregation validation #238

Merged
merged 10 commits into from
Nov 26, 2024
Merged

feat: aggregation validation #238

merged 10 commits into from
Nov 26, 2024

Conversation

vitaligi
Copy link
Contributor

  • added zod validation for aggregation
  • updated zod part schema

@vitaligi vitaligi self-assigned this Nov 26, 2024
CL-SHLOMIKONCHA
CL-SHLOMIKONCHA requested changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@CL-SHLOMIKONCHA CL-SHLOMIKONCHA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We talked about fix the filesName regex
  • We talked about add refine error message in case of begin or end part imaging date is later than current date time

@vitaligi vitaligi merged commit c9f8a64 into master Nov 26, 2024
7 checks passed
@vitaligi vitaligi deleted the aggregation-validation branch November 26, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CL-SHLOMIKONCHA CL-SHLOMIKONCHA CL-SHLOMIKONCHA approved these changes

Assignees

@vitaligi vitaligi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitaligi @CL-SHLOMIKONCHA