Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: adding records entity for transparency + tileFormatOutput #159

Merged
merged 2 commits into from
Dec 25, 2022
Merged

feat!: adding records entity for transparency + tileFormatOutput #159

merged 2 commits into from
Dec 25, 2022

Conversation

ronenkapelian
Copy link
Contributor

  • transperancy records (transperant or opaque) -> profile for pycsw
  • tileFormatOutput - png or jpeg for raster internal uses of new ingestion

@ronenkapelian ronenkapelian self-assigned this Dec 21, 2022
asafMasa
asafMasa requested changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@asafMasa asafMasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

src/models/layerMetadata/decorators/property/tsTypes.decorator.ts Outdated Show resolved Hide resolved
src/models/layerMetadata/layerMetadata.ts Outdated Show resolved Hide resolved
src/models/layerMetadata/layerMetadata.ts Outdated Show resolved Hide resolved
src/yaml/fullLayerMetadata.yaml Outdated Show resolved Hide resolved
@RonitKissis RonitKissis requested a review from netanelC December 22, 2022 11:26
netanelC
netanelC approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@netanelC netanelC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amm.. Fine job.. Get H"H

alebinson
alebinson approved these changes Dec 25, 2022
View reviewed changes
Copy link
Contributor

@alebinson alebinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ronenkapelian ronenkapelian merged commit 8e99f5b into master Dec 25, 2022
@ronenkapelian ronenkapelian deleted the transparency-tileFormat-entities branch December 25, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonitKissis RonitKissis RonitKissis approved these changes

@netanelC netanelC netanelC approved these changes

@alebinson alebinson alebinson approved these changes

@asafMasa asafMasa asafMasa approved these changes

Assignees

@ronenkapelian ronenkapelian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ronenkapelian @asafMasa @alebinson @netanelC @RonitKissis