feat: add storage route (MAPCO-2932) #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shimoncohen
commented
Mar 19, 2023
shimoncohen
commented
| Question | Answer |
|---|---|
| Bug fix | ✖ |
| New feature | ✔ |
| Breaking change | ✖ |
| Deprecations | ✖ |
| Documentation | ✖ |
| Tests added | ✔ |
| Chore | ✔ |
|
|
||
| describe('GetStorage', () => { | ||
| /** | ||
| * @deprecated GetMap API - will be deprecated on future |
There was a problem hiding this comment.
why deprecated notation? if it was accidently copies from reference tests, remove the notation
| import { StorageManager } from '../models/storageManager'; | ||
| import { IStorageStatusResponse } from '../../common/interfaces' | ||
|
|
||
| type GetTaskByJobIdHandler = RequestHandler<{ jobId: string }, IStorageStatusResponse, string>; |
There was a problem hiding this comment.
the name of the type is confusing, mabye i missing something but I think the name should be relative to the issue of storage
There was a problem hiding this comment.
My mistake, renamed.
ronenkapelian
requested changes
Mar 19, 2023
asafMasa
requested changes
Mar 19, 2023
| * @deprecated GetMap API - will be deprecated on future | ||
| */ | ||
| describe('#getStorage', () => { | ||
| it.only('should return storage status', async () => { |
ronenkapelian
approved these changes
Mar 20, 2023
asafMasa
requested changes
Mar 20, 2023
asafMasa
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.