Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: first commit for new cleanup managment logic (MAPCO-2877) (MAPCO-2878) #56

Merged
merged 4 commits into from
Mar 12, 2023
Merged

feat: first commit for new cleanup managment logic (MAPCO-2877) (MAPCO-2878) #56

merged 4 commits into from
Mar 12, 2023

Conversation

ronenkapelian
Copy link
Contributor

Generic cleanupData

Question Answer
Bug fix ✔
New feature ✔
Breaking change ✔
Deprecations ✖
Documentation ✖
Tests added ✔
Chore ✔

As we would like to reuse exporter-clean as generic cleanup tool for jobs on jobManager, we would like create dedicated object in params that responsible for "what" and "when" to delete

@ronenkapelian ronenkapelian self-assigned this Mar 9, 2023
asafMasa
asafMasa requested changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@asafMasa asafMasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good job

src/clients/jobManagerWrapper.ts Outdated Show resolved Hide resolved
src/tasks/models/tasksManager.ts Outdated Show resolved Hide resolved
src/tasks/models/tasksManager.ts Outdated Show resolved Hide resolved
@ronenkapelian ronenkapelian changed the title feat: first commit for new cleanup managment logic feat: first commit for new cleanup managment logic (MAPCO-2878) Mar 9, 2023
asafMasa
asafMasa approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@asafMasa asafMasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ronenkapelian ronenkapelian changed the title feat: first commit for new cleanup managment logic (MAPCO-2878) feat: first commit for new cleanup managment logic (MAPCO-2877) (MAPCO-2878) Mar 9, 2023
@ronenkapelian ronenkapelian marked this pull request as ready for review March 9, 2023 14:36
@ronenkapelian ronenkapelian merged commit d3b47b7 into master Mar 12, 2023
@ronenkapelian ronenkapelian deleted the cleanup-data branch March 12, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asafMasa asafMasa asafMasa approved these changes

Assignees

@ronenkapelian ronenkapelian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronenkapelian @asafMasa