Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: layer polygon parts on metadata json #45

Merged
merged 4 commits into from
Dec 14, 2022

Conversation

AnguIar
Copy link
Collaborator

@AnguIar AnguIar commented Dec 13, 2022

No description provided.

Copy link
Contributor

@asafMasa asafMasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

src/createPackage/models/createPackageManager.ts Outdated Show resolved Hide resolved

private extractPolygonParts(layerPolygonParts: FeatureCollection, sanitizedBboxPolygonzied: Feature<Polygon>): FeatureCollection {
this.logger.info(`Extracting layerPolygonParts from original record that intersects with sanitized bbox`);
let newPolygonLarts = layerPolygonParts;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should create empty feature connection

let newPolygonLarts = layerPolygonParts;
const newFeatures: Feature[] = [];

newPolygonLarts.features.forEach((feature) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

layerPolygonParts.features.forEach((feature) => {

@AnguIar AnguIar merged commit 7a745be into master Dec 14, 2022
@AnguIar AnguIar deleted the metadata_json_polygonparts_fix branch December 14, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants