Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init config error handling #14

Open
ronenkapelian opened this issue Oct 20, 2024 · 0 comments
Open

init config error handling #14

ronenkapelian opened this issue Oct 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ronenkapelian
Copy link
Contributor

long story - short story :
scenario: making config initialization with offlinemode=false, so it tries to connect to the config server.

expected results:
it will be connected to the server if it is successful, if failed, it will return east to understand the error message.

actual:-
on success - it's greater :-)

on some errors:
If the server does not exist: "ConfigError [httpGeneralError]: An error occurred while making the request" good response.

if the server does not exist and the page it reached is not JSON - got an error from undici about bad parsing

@ronenkapelian ronenkapelian added the enhancement New feature or request label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant