Handle nil OCI authenticator with malformed registry

Fixes fluxcd#896 Signed-off-by: Adrien Fillon <[email protected]>
ManoManoTech · Sep 13, 2022 · 03ba63b · 03ba63b
1 parent 9e853a9
commit 03ba63b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/controllers/helmrepository_controller_oci.go b/controllers/helmrepository_controller_oci.go
@@ -382,5 +382,9 @@ func oidcAuthFromAdapter(ctx context.Context, url, provider string) (helmreg.Log
 		return nil, err
 	}
 
+	if auth == nil {
+		return nil, fmt.Errorf("could not validate OCI provider %s with URL %s", provider, url)
+	}
+
 	return registry.OIDCAdaptHelper(auth)
 }
diff --git a/controllers/helmrepository_controller_oci_test.go b/controllers/helmrepository_controller_oci_test.go
@@ -229,6 +229,15 @@ func TestHelmRepositoryOCIReconciler_authStrategy(t *testing.T) {
 				*conditions.FalseCondition(meta.ReadyCondition, sourcev1.AuthenticationFailedReason, "failed to get credential from"),
 			},
 		},
+		{
+			name:        "with contextual login provider and invalid repository URL",
+			wantErr:     true,
+			provider:    "aws",
+			providerImg: "oci://123456789000.dkr.ecr.us-east-2.amazonaws.com",
+			assertConditions: []metav1.Condition{
+				*conditions.FalseCondition(meta.ReadyCondition, sourcev1.AuthenticationFailedReason, "failed to get credential from"),
+			},
+		},
 		{
 			name: "with contextual login provider and secretRef",
 			want: ctrl.Result{RequeueAfter: interval},