Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing naming and/or usage of Ratelimit->ResetTimeMillis #478

Closed
leihog opened this issue Apr 7, 2021 · 2 comments
Closed

Confusing naming and/or usage of Ratelimit->ResetTimeMillis #478

leihog opened this issue Apr 7, 2021 · 2 comments
Labels
to be considered

Comments

@leihog
Copy link

leihog commented Apr 7, 2021

The documentation for rate limiting states that the reset time is a timestamp.

RateLimit-ResetTimeMillis as well as the examples in this repository suggests that the returned value would be the number of milliseconds until a reset.

The actual value returned is a unix timestamp approximately $IntervalMinutes in the future.

Unix timestamps are in seconds not milliseconds. So to avoid confusion the property should be renamed or at least
the example in the README should be updated to reflect that the returned value is a timestamp and not milliseconds until reset as is stated.

:)
@fredericdelordm
Copy link
Contributor

Hello @leihog,

Thank you for your suggestion. Our team is reviewing it.

Have a nice day,

@SoloJr SoloJr mentioned this issue May 4, 2021
Merged
@fredericdelordm
Copy link
Contributor

Hello @leihog,

This has been added in our latest release : 3.4.0

Have a nice day,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
to be considered
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leihog @fredericdelordm