Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#345 - GetEMoney() invoked with 1 parameter, 3 required. #355

Closed
williamdes opened this issue Sep 12, 2019 · 4 comments
Closed

#345 - GetEMoney() invoked with 1 parameter, 3 required. #355

williamdes opened this issue Sep 12, 2019 · 4 comments
Assignees
Milestone

Comments

@williamdes
Copy link
Contributor

Introduced by: #345

public function GetEMoney($userId, $year, $month)

Could you please fix this because you released a version https://github.com/Mangopay/mangopay2-php-sdk/releases/tag/2.12.2 breaking semver since the parameters are not optionally defined

This change also breaks phpstan

  Line   app/Services/Mangopay/xxx.php                            
 ------ ------------------------------------------------------------------- 
  109    Method MangoPay\ApiUsers::GetEMoney() invoked with 1 parameter, 3  
         required.

Thanks :)

cc @mickaelpois

@boherm
Copy link

boherm commented Sep 12, 2019

Same here...

{#3735 +"message": "Too few arguments to function MangoPay\ApiUsers::GetEMoney(), 1 passed in xxx.php on line 131 and exactly 3 expected" +"exception": "Symfony\Component\Debug\Exception\FatalThrowableError" +"file": "/var/www/vendor/mangopay/php-sdk-v2/MangoPay/ApiUsers.php" +"line": 345

@williamdes
Copy link
Contributor Author

@mickaelpois did you see this issue ?

@mickaelpois
Copy link
Contributor

Fixed on 2.13.0

@mickaelpois mickaelpois added this to the 2.13.0 milestone Jan 8, 2020
@williamdes
Copy link
Contributor Author

Thank you @mickaelpois

  • The CHANGELOG entries are missing

I will wait for the tag to be pushed ;)

Ref: #363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants