Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccsh CSVimporter produces almost empty AttributeDescriptors, which break tooltip logic in the Visualization #3642

Open
phanlezz opened this issue Jun 14, 2024 · 0 comments
Labels
bug Only issues that describe bugs. pr-analysis Issues that touch the analysis pr(oject).

Comments

@phanlezz
Copy link
Collaborator

phanlezz commented Jun 14, 2024

CSVimporter produces almost empty AttributeDescriptors, disrupts UI in visualization

Expected Behavior

cc.json generated by CSVimporter

WHEN loading it into the front end

THEN I would expect to get default metric description (e.g. in the legend), as the parser does not provide extended metadata

ℹ️ Key Point: Default Metric Descriptions won't get used, altho they are more excessive in this case ℹ️

Actual Behavior

The empty strings from the AttributeDescriptors get used to build titles, tooltips, etc.

Screenshots

grafik

grafik

Dev Comments

We put the direction in the AttributeDescriptors, but every other field is empty. Because the Visualization assumes that there is a description if there is an entry in the AttributeDescriptors Map, it builds up the title etc. from empty strings.

  1. We could change the behavior in the analysis, so that the Descriptors won't be included in CSVimporter (directions would be missing)
    • To mitigate that issue, we could evaluate moving the direction to attributeTypes instead of AttributeDescriptions.
  2. We could include an empty string check in the Visualization, so that it is able to fall back to the metricTitles.ts to build UI elements

Steps to Reproduce the Problem

  1. Use the CSVimporter (tested with the golden_test example file)

actual_csvimport.cc.json
Caution: The MCC entry got already removed for testing purposes!

  1. Load into visualization
  2. Check legend panel

Specifications

  • is released in online-demo: yes
  • CodeCharta Version: 1.126.0
  • OS: Windows (irrelevant)
  • Browser: Firefox (irrelevant)
@phanlezz phanlezz added bug Only issues that describe bugs. pr-analysis Issues that touch the analysis pr(oject). labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Only issues that describe bugs. pr-analysis Issues that touch the analysis pr(oject).
Projects
None yet
Development

No branches or pull requests

1 participant