Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annoying exceptions Using Delphi 10.2 Version 25.0.27659.1188 #11

Open
sysbndt opened this issue Aug 28, 2017 · 2 comments
Open

Annoying exceptions Using Delphi 10.2 Version 25.0.27659.1188 #11

sysbndt opened this issue Aug 28, 2017 · 2 comments

Comments

@sysbndt
Copy link

sysbndt commented Aug 28, 2017

When using Delphi 10.2 Version 25.0.27659.1188, 32 bits debug configuration, there are very annoying exceptions triggered in DecodeBranch_Ev on the line "AM_32: P := PByte(PUInt32(P)^);".

They are ignored by a try/except but this make DebugEngine almost unusable in a real project while debugging. The exception pops up while working as soon as a stack trace is build.

Instead of capturing the exception with try/except, it should be avoided.

By the way, the exceptions I saw where triggered because the address (Variable P in the code) fall in the first KB of memory which is a protected area. A simple test would avoid the exception.

@MahdiSafsafi
Copy link
Owner

Yes you're totally right. Calculating branch address should not be a part of the disassembler. I should move that routine to DebugEngine in that way I can verify address before accessing it.

@sysbndt
Copy link
Author

sysbndt commented Aug 29, 2017

In my opinion, given the fact that you generously make your code available on GitHub, you should fix this kind of problem and the other I reported yesterday (Integer overflow) if you want to have your code used by other developers and enter the hall of Delphi fames :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants