Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the interaction of calendar #151

Closed
Keith-CY opened this issue May 16, 2023 · 7 comments
Closed

Optimize the interaction of calendar #151

Keith-CY opened this issue May 16, 2023 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@Keith-CY
Copy link
Member

As mentioned at nervosnetwork/neuron#2592 (comment)

The selected year, month will not be effective if it's saved before day is selected, which is weird and prone to select tomorrow.

Say the pre-picked time is 2023/05/17, and 2024/07 are selected, however, 2023/05/17 will be saved if save is clicked without selecting day

neuron_calendar_behavior.mov
@Keith-CY Keith-CY added the bug Something isn't working label May 16, 2023
@Keith-CY Keith-CY added this to Neuron May 16, 2023
@Danie0918 Danie0918 moved this to 🆕 New in Neuron May 16, 2023
@Danie0918 Danie0918 moved this from 🆕 New to 🏗 In Progress in Neuron May 16, 2023
@Danie0918 Danie0918 assigned WhiteMinds and unassigned Sven-TBD and Danie0918 May 16, 2023
@WhiteMinds
Copy link

I feel that not automatically changing the value when switching between years and months is a common behavior and quite reasonable. It seems more like an interaction design rather than a logical bug.
If we want to optimize this, perhaps we should have the "Save" button initially disabled until the user manually makes a change.
In this way, providing a default value for tomorrow might not be necessary, and we can omit the default value but offer a shortcut button like "Tomorrow" to assist in quickly selecting a value.

@Danie0918 @Keith-CY What do you think about this?

@Keith-CY
Copy link
Member Author

I feel that not automatically changing the value when switching between years and months is a common behavior and quite reasonable. It seems more like an interaction design rather than a logical bug. If we want to optimize this, perhaps we should have the "Save" button initially disabled until the user manually makes a change. In this way, providing a default value for tomorrow might not be necessary, and we can omit the default value but offer a shortcut button like "Tomorrow" to assist in quickly selecting a value.

@Danie0918 @Keith-CY What do you think about this?

Indeed, it could be optimized from UX.
Enabling the save button after an interaction is good for me.

@WhiteMinds
Copy link

WhiteMinds commented May 18, 2023

iShot_2023-05-18_10.52.38.mp4

The overall effect would be like this. I think if the goal is to prevent saving unintended values, it might be better to provide a time preview near the save button. That way, users can have a better understanding of the value they are about to save.
The follow was just an example, and the actual style needs to be determined by the designer:

image image

@yanguoyu
Copy link

I think it's better to disable save when the user does not select any date. Otherwise, the user may confuse with the new date.

@Keith-CY
Copy link
Member Author

Any idea from @Danie0918 @Sven-TBD

@Danie0918
Copy link
Contributor

Danie0918 commented May 18, 2023

Calendar selection is indeed a common function that needs to be protected against accidental touches, especially when it affects transactions.

There are 2 situations here:

  1. When no date is selected, the "Save" button is not displayed, and the "Cancel" button is changed to "Close"
  2. After selecting the date, the user needs to be prompted to select the date. Here, the style 2 mentioned in the WhiteMinds's comment is used. It is recommended to change "save" to "lock to"

image

@WhiteMinds
Copy link

PR: nervosnetwork/neuron#2674

Please have @Danie0918 review the effect presentation in the PR to ensure it meets the expectations.

@Danie0918 Danie0918 moved this from 🏗 In Progress to 🚩Pre Release in Neuron May 29, 2023
@Danie0918 Danie0918 moved this from 🚩Pre Release to ✅ Done in Neuron Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

5 participants