Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys.exit(...) exception swallowed by uvloop #612

Open
rgeronimi opened this issue Jul 28, 2024 · 0 comments
Open

sys.exit(...) exception swallowed by uvloop #612

rgeronimi opened this issue Jul 28, 2024 · 0 comments

Comments

@rgeronimi
Copy link

rgeronimi commented Jul 28, 2024

  • uvloop version:
    0.19.0

  • Python version:
    3.11.9

  • Platform:
    MacOS 14.5 (Sonoma)
    mamba 1.5.8
    conda 24.5.0

  • Can you reproduce the bug with PYTHONASYNCIODEBUG in env?:
    Not yet

  • Does uvloop behave differently from vanilla asyncio? How?:
    I have never had this bug with vanilla asyncio

If a sys.exit(...) call is made while uvloop is being used in coroutines (in my case, through aiohttp crawling of web URLs), uvloop may catch the SystemExit exception, and not let it bubble as a SystemExit to the top of the application. Instead, it logs this at the ERROR level:

2024-07-26 06:25:06,802 ERROR asyncio Fatal error on transport TCPTransport
protocol: <uvloop.loop.SSLProtocol object at 0x16b54de80>
transport: <TCPTransport closed=False reading=False 0x1693bfff0>
Traceback (most recent call last):
  File "uvloop/handles/stream.pyx", line 1007, in uvloop.loop.__uv_stream_buffered_on_read
  File "uvloop/loop.pyx", line 109, in uvloop.loop.run_in_context1
  File "uvloop/sslproto.pyx", line 382, in uvloop.loop.SSLProtocol.buffer_updated
  File "uvloop/sslproto.pyx", line 711, in uvloop.loop.SSLProtocol._do_read
  File "uvloop/sslproto.pyx", line 776, in uvloop.loop.SSLProtocol._do_read__copied
  File "/opt/homebrew/Caskroom/miniforge/base/envs/work/lib/python3.11/ssl.py", line 912, in read
    def read(self, len=1024, buffer=None):
    
  File "/Users/dmoklaf/Local/metax/python_libraries/application.py", line 171, in _exit
    sys.exit(code)
SystemExit: 1

Indeed, a quick look at the uvloop code shows that it logs the SystemExit exception, as SystemExit does not subclass OSError:

cdef _fatal_error(self, exc, throw, reason=None):

PS: there also seems to be other _fatal_error implementations in uvloop, I am not completely sure if these other places do not suffer from the same issue

And it also swallows the SystemExit exception, instead of propagating it upward as requested by the Python specification.

@rgeronimi rgeronimi changed the title sys.exit(...) exception catched by uvloop sys.exit(...) exception swallowed by uvloop Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant