Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display every module coverage report #77

Open
MGaetan89 opened this issue Jan 24, 2024 · 4 comments
Open

Display every module coverage report #77

MGaetan89 opened this issue Jan 24, 2024 · 4 comments
Labels
feature request New feature or request

Comments

@MGaetan89
Copy link

Currently, it seems that only modules with changed files are shown in the PR comment. Would it be possible to add an option to always display the coverage information of every modules, even the changed files are not in these modules?

@instrap instrap added the feature request New feature or request label Sep 8, 2024
@instrap
Copy link
Member

instrap commented Sep 8, 2024

We are not sure how useful this would be. I am gonna keep this open for a while to see if other users upvote this. If so, we will pick this up. Maybe not in the PR comment, but as a Workflow Job Summary.

@instrap
Copy link
Member

instrap commented Sep 20, 2024

This may turn out to be useful for events like push, schedule, workflow_dispatch, when there is no head vs base commit sha to compare, but only one brach to work with. So essentially, there won't be any "changed files" at all, but only the entire project. Right now, in such cases, we only report the Overall Project coverage. It would be useful to also show the Modules coverage.

@thsaravana
Copy link
Member

I think we should do this, may be just for the Workflow Summary. We should also probably consider minimizing the 'Modules' table if there are more than 5 rows. If a project, usually android, has 20 modules, it wouldn't be nice to show a table with 20 rows always expanded.

@mgafarov
Copy link

mgafarov commented Oct 6, 2024

We also have such case when we need to show summary coverage of all modules even if this modules didn't change. Would be great to have such functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants