-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(GUS) Crash On Exit #20
Comments
Calling |
Neat. I can take a look at this tomorrow. |
When you have a chance, please give this .dmg binary a try to see if it closes cleanly: https://github.com/dosbox-staging/dosbox-staging/suites/1796459154/artifacts/34430219 Much thanks 👍 |
Thanks to Magamo for testing the binary https://github.com/dosbox-staging/dosbox-staging/suites/1796459154/artifacts/34430219 on hardware.
This build was from the |
There's another crash-at-exit in Boxer not related to GUS. Opening a new issue (#26). |
Closing the window doesn't cause the crash; typing |
Hi, I built the latest code and I can reproduce this crash always when exit with Cmd + Q during a game execution. Seems that I think these variables might be destroyed (at compiler discretion) before The most non-intrusive fix should be replacing:
with:
and removed the extern declarations at inout.h. It works, but it's quick-and-dirty. Hope it helps to find a better solution. |
First, thanks for taking the time to maintain this fork.
I built a release build of Boxer using Xcode's Archive functionality. App appears to work fine and games play without issue. However almost every time I quit Boxer, I get this crash. I'm not a C++ dev (Obj-c/Swift iOS dev by trade) so I can't follow the stack trace terribly well but it looks like potentially an open IO pointer is left open during application exit when the NSMenuItem goes to terminate?
Let me know how else I can help. I built this against hash
a822a205a06112696202e1f64c5976edf726f90b
The text was updated successfully, but these errors were encountered: