From 560ca6d4e4951e80a3f4bc8135a47beb188fbae9 Mon Sep 17 00:00:00 2001 From: xing-zhi Date: Wed, 15 Feb 2017 15:47:55 +0800 Subject: [PATCH 1/2] only add backgroud image with the '?__spriter' suffix --- ...er-styles-and-transform-background-image-declarations.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/map-over-styles-and-transform-background-image-declarations.js b/lib/map-over-styles-and-transform-background-image-declarations.js index de1560a..faace77 100644 --- a/lib/map-over-styles-and-transform-background-image-declarations.js +++ b/lib/map-over-styles-and-transform-background-image-declarations.js @@ -39,6 +39,11 @@ function mapOverStylesAndTransformAllBackgroundImageDeclarations(styles, cb) { var transformedDeclaration = extend(true, {}, declaration); transformedDeclaration = attachInfoToDeclaration(declarations, declarationIndex); + // only add backgroud image with the '?__spriter' suffix + var declarValue = transformedDeclaration.value; + + if (/\?__spriter/i.test(declarValue)) { + transformedDeclaration.value = declarValue.replace('?__spriter', ''); // background-image always has a url if(transformedDeclaration.property === 'background-image') { return cb(transformedDeclaration, declarationIndex, declarations); @@ -51,6 +56,7 @@ function mapOverStylesAndTransformAllBackgroundImageDeclarations(styles, cb) { return cb(transformedDeclaration, declarationIndex, declarations); } } + } // Wrap in an object so that the declaration doesn't get interpreted return { From 245f4717e427fe2846c40792f45f365f14220758 Mon Sep 17 00:00:00 2001 From: xing-zhi Date: Wed, 15 Feb 2017 15:51:55 +0800 Subject: [PATCH 2/2] better variable name --- ...er-styles-and-transform-background-image-declarations.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/map-over-styles-and-transform-background-image-declarations.js b/lib/map-over-styles-and-transform-background-image-declarations.js index faace77..ff6d8a8 100644 --- a/lib/map-over-styles-and-transform-background-image-declarations.js +++ b/lib/map-over-styles-and-transform-background-image-declarations.js @@ -40,10 +40,10 @@ function mapOverStylesAndTransformAllBackgroundImageDeclarations(styles, cb) { transformedDeclaration = attachInfoToDeclaration(declarations, declarationIndex); // only add backgroud image with the '?__spriter' suffix - var declarValue = transformedDeclaration.value; + var declarationValue = transformedDeclaration.value; - if (/\?__spriter/i.test(declarValue)) { - transformedDeclaration.value = declarValue.replace('?__spriter', ''); + if (/\?__spriter/i.test(declarationValue)) { + transformedDeclaration.value = declarationValue.replace('?__spriter', ''); // background-image always has a url if(transformedDeclaration.property === 'background-image') { return cb(transformedDeclaration, declarationIndex, declarations);