Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1D triple well dataset is broken #15

Open
pietronvll opened this issue Oct 10, 2024 · 0 comments
Open

1D triple well dataset is broken #15

pietronvll opened this issue Oct 10, 2024 · 0 comments

Comments

@pietronvll
Copy link
Contributor

The 1D Triple Well potential

class LangevinTripleWell1D(DiscreteTimeDynamics):

is bugged as:

  • The .npz resource files are not being included in the pip installer, and should be loaded using importlib.resources
  • The Boltzmann PDF
    boltzmann_pdf = (dx**-1) * scipy.special.softmax(self.force_fn(cc) / self.kt)
    is wrong, and it should be
    boltzmann_pdf = (dx**-1) * scipy.special.softmax(-self.potential_fn(cc) / self.kt)
    with
    def potential_fn(self, x: ArrayLike) -> ArrayLike:
       """
       See Example 1 of "Modeling Molecular Kinetics with tICA and the Kernel Trick" 10.1021/ct5007357
       """
       return 4 * (
           x**8
           + 0.8 * np.exp(-80 * (x**2))
           + 0.2 * np.exp(-80 * ((x - 0.5) ** 2))
           + 0.5 * np.exp(-40 * ((x + 0.5) ** 2))
       )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant